You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Jake Maes <ja...@gmail.com> on 2016/08/04 22:36:48 UTC
Re: Review Request 47992: Improve logging by adding a startup logger.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47992/#review144836
-----------------------------------------------------------
Closing the loop:
This review has been superseded by https://reviews.apache.org/r/50583/ and can be discarded.
- Jake Maes
On July 20, 2016, 6:01 p.m., Jagadish Venkatraman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47992/
> -----------------------------------------------------------
>
> (Updated July 20, 2016, 6:01 p.m.)
>
>
> Review request for samza, Navina Ramesh and Yi Pan (Data Infrastructure).
>
>
> Repository: samza
>
>
> Description
> -------
>
> Often Samza jobs keep running for days (and in our case months). Log messages generated by the job get rolled over. A lot of information that is critical for debugging a job (like the jmx server port, URL, job model for the current container, configuration that was passed to the container) is often printed when the job starts. However, since logs get rolled over (by Yarn/ by sys-administrators) when they exceed a certain size, this information is not obvious. This RB adds a startup logger to the Logging trait.
>
>
> Diffs
> -----
>
> samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala cf3c4c0ab08a59760bc899c6f2027755e933b350
> samza-core/src/main/scala/org/apache/samza/metrics/JmxServer.scala ad00ca00f918df4d71d1c920b77027401a55c80b
> samza-core/src/main/scala/org/apache/samza/util/Logging.scala 250de1e2fa103be1a426d9da31187c12dbff8678
>
> Diff: https://reviews.apache.org/r/47992/diff/
>
>
> Testing
> -------
>
> <logger name="STARTUP" additivity="false">
> <priority value="info" />
> <appender-ref ref="startup_file_appender"/>
> </logger>
>
> Verified log messages are correctly appended in both main, and startup logs.
>
>
> Thanks,
>
> Jagadish Venkatraman
>
>