You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by zh...@gmail.com on 2010/05/20 17:58:58 UTC

Use UriCommon from AbstractHttpCache (issue1232044)

Reviewers: shindig.remailer_gmail.com,

Description:
Simple dependency cleanup and use of UriCommon instead of ImageRewriter.

Please review this at http://codereview.appspot.com/1232044/show

Affected files:
    
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java


### Eclipse Workspace Patch 1.0
#P shindig-project
Index:  
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java
===================================================================
---  
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java	 
(revision 944496)
+++  
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/AbstractHttpCache.java	 
(working copy)
@@ -17,15 +17,12 @@
   */
  package org.apache.shindig.gadgets.http;

-import static  
org.apache.shindig.gadgets.rewrite.image.BasicImageRewriter.PARAM_RESIZE_HEIGHT;
-import static  
org.apache.shindig.gadgets.rewrite.image.BasicImageRewriter.PARAM_RESIZE_QUALITY;
-import static  
org.apache.shindig.gadgets.rewrite.image.BasicImageRewriter.PARAM_RESIZE_WIDTH;
-
  import com.google.inject.Inject;

  import org.apache.shindig.auth.SecurityToken;
  import org.apache.shindig.common.util.TimeSource;
  import org.apache.shindig.gadgets.AuthType;
+import org.apache.shindig.gadgets.uri.UriCommon;

  /**
   * Base class for content caches. Defines cache expiration rules and
@@ -152,9 +149,9 @@
          .setLegacyParam(6, getInstanceId(request))
          .setLegacyParam(7, getServiceName(request))
          .setLegacyParam(8, getTokenName(request))
-        .setParam("rh", request.getParam(PARAM_RESIZE_HEIGHT))
-        .setParam("rw", request.getParam(PARAM_RESIZE_WIDTH))
-        .setParam("rq", request.getParam(PARAM_RESIZE_QUALITY));
+        .setParam("rh",  
request.getParam(UriCommon.Param.RESIZE_HEIGHT.getKey()))
+        .setParam("rw",  
request.getParam(UriCommon.Param.RESIZE_WIDTH.getKey()))
+        .setParam("rq",  
request.getParam(UriCommon.Param.RESIZE_QUALITY.getKey()));

      return keyBuilder.build();
    }