You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Henry Saputra <hs...@apache.org> on 2012/02/07 21:41:11 UTC
Review Request: SHINDIG-1701 Change the action_container.js rpc registration
to call the Container.rpcRegister instead directly call gadgets.rpc.register
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3777/
-----------------------------------------------------------
Review request for shindig, Ryan Baxter and Dan Dumont.
Summary
-------
See jira https://issues.apache.org/jira/browse/SHINDIG-1701
This addresses bug SHINDIG-1701.
https://issues.apache.org/jira/browse/SHINDIG-1701
Diffs
-----
trunk/features/src/main/javascript/features/actions/actions_container.js 1241570
Diff: https://reviews.apache.org/r/3777/diff
Testing
-------
Run mvn clean install and sanity test with conservcontainer
Thanks,
Henry
Re: Review Request: SHINDIG-1701 Change the action_container.js rpc
registration to call the Container.rpcRegister instead directly call
gadgets.rpc.register
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3777/#review4892
-----------------------------------------------------------
Ship it!
LGTM
- Ryan
On 2012-02-07 22:41:01, Henry Saputra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3777/
> -----------------------------------------------------------
>
> (Updated 2012-02-07 22:41:01)
>
>
> Review request for shindig, Ryan Baxter and Dan Dumont.
>
>
> Summary
> -------
>
> See jira https://issues.apache.org/jira/browse/SHINDIG-1701
>
>
> This addresses bug SHINDIG-1701.
> https://issues.apache.org/jira/browse/SHINDIG-1701
>
>
> Diffs
> -----
>
> trunk/features/src/main/javascript/features/actions/actions_container.js 1241570
>
> Diff: https://reviews.apache.org/r/3777/diff
>
>
> Testing
> -------
>
> Run mvn clean install and sanity test with conservcontainer
>
>
> Thanks,
>
> Henry
>
>
Re: Review Request: SHINDIG-1701 Change the action_container.js rpc
registration to call the Container.rpcRegister instead directly call
gadgets.rpc.register
Posted by Henry Saputra <hs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3777/#review4893
-----------------------------------------------------------
Thanks, committed as rev 1241749
- Henry
On 2012-02-07 22:41:01, Henry Saputra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3777/
> -----------------------------------------------------------
>
> (Updated 2012-02-07 22:41:01)
>
>
> Review request for shindig, Ryan Baxter and Dan Dumont.
>
>
> Summary
> -------
>
> See jira https://issues.apache.org/jira/browse/SHINDIG-1701
>
>
> This addresses bug SHINDIG-1701.
> https://issues.apache.org/jira/browse/SHINDIG-1701
>
>
> Diffs
> -----
>
> trunk/features/src/main/javascript/features/actions/actions_container.js 1241570
>
> Diff: https://reviews.apache.org/r/3777/diff
>
>
> Testing
> -------
>
> Run mvn clean install and sanity test with conservcontainer
>
>
> Thanks,
>
> Henry
>
>
Re: Review Request: SHINDIG-1701 Change the action_container.js rpc
registration to call the Container.rpcRegister instead directly call
gadgets.rpc.register
Posted by Henry Saputra <hs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3777/
-----------------------------------------------------------
(Updated 2012-02-07 22:41:01.934131)
Review request for shindig, Ryan Baxter and Dan Dumont.
Changes
-------
Upload new diff based on Ryan review
Summary
-------
See jira https://issues.apache.org/jira/browse/SHINDIG-1701
This addresses bug SHINDIG-1701.
https://issues.apache.org/jira/browse/SHINDIG-1701
Diffs (updated)
-----
trunk/features/src/main/javascript/features/actions/actions_container.js 1241570
Diff: https://reviews.apache.org/r/3777/diff
Testing
-------
Run mvn clean install and sanity test with conservcontainer
Thanks,
Henry
Re: Review Request: SHINDIG-1701 Change the action_container.js rpc
registration to call the Container.rpcRegister instead directly call
gadgets.rpc.register
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3777/#review4879
-----------------------------------------------------------
trunk/features/src/main/javascript/features/actions/actions_container.js
<https://reviews.apache.org/r/3777/#comment10753>
Instead of having these new wrapper functions I would prefer if we could make them inline functions passed to rpcRegister
- Ryan
On 2012-02-07 20:41:11, Henry Saputra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3777/
> -----------------------------------------------------------
>
> (Updated 2012-02-07 20:41:11)
>
>
> Review request for shindig, Ryan Baxter and Dan Dumont.
>
>
> Summary
> -------
>
> See jira https://issues.apache.org/jira/browse/SHINDIG-1701
>
>
> This addresses bug SHINDIG-1701.
> https://issues.apache.org/jira/browse/SHINDIG-1701
>
>
> Diffs
> -----
>
> trunk/features/src/main/javascript/features/actions/actions_container.js 1241570
>
> Diff: https://reviews.apache.org/r/3777/diff
>
>
> Testing
> -------
>
> Run mvn clean install and sanity test with conservcontainer
>
>
> Thanks,
>
> Henry
>
>