You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "tiagobento (via GitHub)" <gi...@apache.org> on 2024/01/05 21:22:17 UTC
[PR] kie-issues#783: Standardize the use of path strings on Apache KIE Editors [incubator-kie-tools]
tiagobento opened a new pull request, #2112:
URL: https://github.com/apache/incubator-kie-tools/pull/2112
Closes https://github.com/apache/incubator-kie-issues/issues/783
---
Description coming soon...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#783: Standardize the use of path strings on Apache KIE Editors [incubator-kie-tools]
Posted by "caponetto (via GitHub)" <gi...@apache.org>.
caponetto commented on code in PR #2112:
URL: https://github.com/apache/incubator-kie-tools/pull/2112#discussion_r1450536787
##########
packages/operating-system/src/paths.ts:
##########
@@ -0,0 +1,9 @@
+import * as __path from "path";
Review Comment:
Great, thanks you ❤️
##########
packages/operating-system/src/paths.ts:
##########
@@ -0,0 +1,9 @@
+import * as __path from "path";
Review Comment:
Great, thank you ❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#783: Standardize the use of path strings on Apache KIE Editors [incubator-kie-tools]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on code in PR #2112:
URL: https://github.com/apache/incubator-kie-tools/pull/2112#discussion_r1450526847
##########
packages/operating-system/src/paths.ts:
##########
@@ -0,0 +1,9 @@
+import * as __path from "path";
Review Comment:
We already has the polyfill configured on our common Webpack config.. Do you mean sometimes we are not using the common Webpack config?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#783: Standardize the use of path strings on Apache KIE Editors [incubator-kie-tools]
Posted by "caponetto (via GitHub)" <gi...@apache.org>.
caponetto commented on code in PR #2112:
URL: https://github.com/apache/incubator-kie-tools/pull/2112#discussion_r1448866804
##########
packages/dashbuilder-viewer/dev-webapp/App.tsx:
##########
@@ -39,12 +39,13 @@ pages:
- components:
- html: <h1>Welcome to Dashbuilder!</h1>`;
-const FILE = {
+const FILE: EmbeddedEditorFile = {
fileName: "test.dash.yaml",
fileExtension: "dash.yaml",
getFileContents: function (): Promise<string | undefined> {
return Promise.resolve(TEST_CONTENT);
},
+ normalizedPosixPathRelativeToTheWorkspaceRoot: "",
Review Comment:
```suggestion
normalizedPosixPathRelativeToTheWorkspaceRoot: "test.dash.yaml",
```
Otherwise, we see `No Editor available for 'dash.yaml' extension` when running the test webapp.
##########
packages/operating-system/src/paths.ts:
##########
@@ -0,0 +1,9 @@
+import * as __path from "path";
Review Comment:
Can we move this file to `vscode-extension` package? I see this is being used only in there.
Or use `path-browserify` instead of `path`.
My concern is other core packages starting to use this file, which will make polyfill mandatory for webapps. Sometimes polyfill are not under our control.
##########
packages/dashbuilder-editor/dev-webapp/App.tsx:
##########
@@ -33,12 +33,13 @@ import "./App.scss";
export type ServerlessWorkflowType = "yml" | "yaml";
-const FILE = {
+const FILE: EmbeddedEditorFile = {
fileName: "test.dash.yaml",
fileExtension: "dash.yaml",
getFileContents: function (): Promise<string | undefined> {
return Promise.resolve("");
},
+ normalizedPosixPathRelativeToTheWorkspaceRoot: "",
Review Comment:
```suggestion
normalizedPosixPathRelativeToTheWorkspaceRoot: "test.dash.yaml",
```
Otherwise, we see `No Editor available for 'dash.yaml' extension` when running the test webapp.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#783: Standardize the use of path strings on Apache KIE Editors [incubator-kie-tools]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on code in PR #2112:
URL: https://github.com/apache/incubator-kie-tools/pull/2112#discussion_r1450535366
##########
packages/operating-system/src/paths.ts:
##########
@@ -0,0 +1,9 @@
+import * as __path from "path";
Review Comment:
Ok, got it. I guess it's fair to have this only in VS Code, given all other channels are not platform-specific, so we don't really have to deal with Windows paths :)
I'll apply the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#783: Standardize the use of path strings on Apache KIE Editors [incubator-kie-tools]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on PR #2112:
URL: https://github.com/apache/incubator-kie-tools/pull/2112#issuecomment-1883988583
@caponetto or @paulovmr May I ask for your help with executing the tests for SWF/YARD/DASHBUILDER?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#783: Standardize the use of path strings on Apache KIE Editors [incubator-kie-tools]
Posted by "caponetto (via GitHub)" <gi...@apache.org>.
caponetto commented on code in PR #2112:
URL: https://github.com/apache/incubator-kie-tools/pull/2112#discussion_r1450531732
##########
packages/operating-system/src/paths.ts:
##########
@@ -0,0 +1,9 @@
+import * as __path from "path";
Review Comment:
We are using some SWF packages outside kie-tools and the webapp in question disables most of polyfills, including the one for path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#783: Standardize the use of path strings on Apache KIE Editors [incubator-kie-tools]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento merged PR #2112:
URL: https://github.com/apache/incubator-kie-tools/pull/2112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org