You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by eiri <gi...@git.apache.org> on 2016/02/05 18:32:22 UTC

[GitHub] couchdb-couch-replicator pull request: Fix the filtered replicatio...

GitHub user eiri opened a pull request:

    https://github.com/apache/couchdb-couch-replicator/pull/24

    Fix the filtered replication tests

    This patch addresses the following issues with `couch_replicator_filtered_tests`
    
    - The test was running an ordinary and not a filtered replication. 
    - The test's setup was propagating both source and target databases with all the docs nullifying the effect of replication.
    - The test was only checking if a filtered doc was found in the target database and not that none-filtered docs hasn't been replicated in there.
    
    I've also added a second test for a filtered with `query_params` replication.
     

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloudant/couchdb-couch-replicator 60467-fix-filtered-replication-tests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-couch-replicator/pull/24.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #24
    
----
commit 074ccda9c657ef82a790cd87c2f836dc1371e129
Author: Eric Avdey <ei...@eiri.ca>
Date:   2016-02-05T15:28:49Z

    Fix filtered replication test

commit 7e107658429f7c84bad212b26db1be95e442e8b0
Author: Eric Avdey <ei...@eiri.ca>
Date:   2016-02-05T17:15:33Z

    Add filtered with query replication test

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch-replicator pull request: Fix the filtered replicatio...

Posted by eiri <gi...@git.apache.org>.

Github user eiri commented on the pull request:

    https://github.com/apache/couchdb-couch-replicator/pull/24#issuecomment-182839861
  
    @kxepal Done :green_apple: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch-replicator pull request: Fix the filtered replicatio...

Posted by kxepal <gi...@git.apache.org>.

Github user kxepal commented on the pull request:

    https://github.com/apache/couchdb-couch-replicator/pull/24#issuecomment-182843449
  
    Great! +1 (:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch-replicator pull request: Fix the filtered replicatio...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/couchdb-couch-replicator/pull/24


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-couch-replicator pull request: Fix the filtered replicatio...

Posted by kxepal <gi...@git.apache.org>.

Github user kxepal commented on the pull request:

    https://github.com/apache/couchdb-couch-replicator/pull/24#issuecomment-182835603
  
    Please rebase for the travis green build. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---