You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "Solomon Duskis (JIRA)" <ji...@apache.org> on 2014/12/01 16:02:12 UTC

[jira] [Commented] (HBASE-12490) Replace uses of setAutoFlush(boolean, boolean)

    [ https://issues.apache.org/jira/browse/HBASE-12490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14229883#comment-14229883 ] 

Solomon Duskis commented on HBASE-12490:
----------------------------------------

Can this please be applied against branch-1?

> Replace uses of setAutoFlush(boolean, boolean)
> ----------------------------------------------
>
>                 Key: HBASE-12490
>                 URL: https://issues.apache.org/jira/browse/HBASE-12490
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0, 0.99.2
>            Reporter: Solomon Duskis
>            Assignee: Solomon Duskis
>         Attachments: HBASE-12490.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490B.patch, HBASE-12490C.patch
>
>
> The various uses of setAutoFlush() seem to need some tlc.  There's a note in HTableInterface: "@deprecated in 0.99 since setting clearBufferOnFail is deprecated. Use setAutoFlushTo(boolean) instead."  It would be ideal to change all internal uses of setAutoFlush(boolean, boolean) to use setAutoFlushTo, if possible.
> HTable.setAutoFlush(boolean, boolean) is used in a handful of places.  setAutoFlush(false, false) has the same results as HTable.setAutoFlush(false).  Calling HTable.setAutoFlush(false, true) has the same affect as Table.setAutoFlushTo(false), assuming HTable.setAutoFlush(false) was not called previously (by default, the second parameter, clearBufferOnFail, is true and should remain true according to the comments). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)