You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/22 04:27:08 UTC
[GitHub] [flink] cpugputpu opened a new pull request #11181:
[FLINK-16230][tests]Use LinkedHashSet instead of HashSet
cpugputpu opened a new pull request #11181: [FLINK-16230][tests]Use LinkedHashSet instead of HashSet
URL: https://github.com/apache/flink/pull/11181
For background information, please refer to https://issues.apache.org/jira/browse/FLINK-16230
## What is the purpose of the change
The fix for the test is to use LinkedHashSet instead of HashSet so that the iteration order will be deterministic across different JVM versions or vendors, thus making the test more stable.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11181:
[FLINK-16230][tests]Use LinkedHashSet instead of HashSet
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11181: [FLINK-16230][tests]Use LinkedHashSet instead of HashSet
URL: https://github.com/apache/flink/pull/11181#issuecomment-589919323
<!--
Meta data
Hash:1adaf381144df070b76f311652607fe295842863 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/150128180 TriggerType:PUSH TriggerID:1adaf381144df070b76f311652607fe295842863
-->
## CI report:
* 1adaf381144df070b76f311652607fe295842863 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150128180)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11181:
[FLINK-16230][tests]Use LinkedHashSet instead of HashSet
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11181: [FLINK-16230][tests]Use LinkedHashSet instead of HashSet
URL: https://github.com/apache/flink/pull/11181#issuecomment-589919323
<!--
Meta data
Hash:1adaf381144df070b76f311652607fe295842863 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/150128180 TriggerType:PUSH TriggerID:1adaf381144df070b76f311652607fe295842863
-->
## CI report:
* 1adaf381144df070b76f311652607fe295842863 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150128180)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11181:
[FLINK-16230][tests]Use LinkedHashSet instead of HashSet
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11181: [FLINK-16230][tests]Use LinkedHashSet instead of HashSet
URL: https://github.com/apache/flink/pull/11181#issuecomment-589919323
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1adaf381144df070b76f311652607fe295842863",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150128180",
"triggerID" : "1adaf381144df070b76f311652607fe295842863",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1adaf381144df070b76f311652607fe295842863 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150128180)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] cpugputpu edited a comment on issue #11181:
[FLINK-16230][tests]Use LinkedHashSet instead of HashSet
Posted by GitBox <gi...@apache.org>.
cpugputpu edited a comment on issue #11181: [FLINK-16230][tests]Use LinkedHashSet instead of HashSet
URL: https://github.com/apache/flink/pull/11181#issuecomment-592532190
Thanks for your valuable comments! Sorry for my delay. I have tried to fix it according to your advice. Under the assumption that the objects properly implement `equals` methods, I fix it by removing the `Iterable` branch. I test it again and find that the flaky test is eliminated in this way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11181:
[FLINK-16230][tests]Use LinkedHashSet instead of HashSet
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11181: [FLINK-16230][tests]Use LinkedHashSet instead of HashSet
URL: https://github.com/apache/flink/pull/11181#issuecomment-589919323
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1adaf381144df070b76f311652607fe295842863",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150128180",
"triggerID" : "1adaf381144df070b76f311652607fe295842863",
"triggerType" : "PUSH"
}, {
"hash" : "6f3bc9cbe941d095afda5455e7d70a428cf79e29",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6f3bc9cbe941d095afda5455e7d70a428cf79e29",
"triggerType" : "PUSH"
}, {
"hash" : "38c3fcdbc15a68c2f70c1c34c22fcf81299933c2",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151160491",
"triggerID" : "38c3fcdbc15a68c2f70c1c34c22fcf81299933c2",
"triggerType" : "PUSH"
}, {
"hash" : "38c3fcdbc15a68c2f70c1c34c22fcf81299933c2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5770",
"triggerID" : "38c3fcdbc15a68c2f70c1c34c22fcf81299933c2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6f3bc9cbe941d095afda5455e7d70a428cf79e29 UNKNOWN
* 38c3fcdbc15a68c2f70c1c34c22fcf81299933c2 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151160491) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5770)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] cpugputpu opened a new pull request #11181:
[FLINK-16230][tests]Use LinkedHashSet instead of HashSet
Posted by GitBox <gi...@apache.org>.
cpugputpu opened a new pull request #11181: [FLINK-16230][tests]Use LinkedHashSet instead of HashSet
URL: https://github.com/apache/flink/pull/11181
For background information, please refer to https://issues.apache.org/jira/browse/FLINK-16230
## What is the purpose of the change
The fix for the test is to use LinkedHashSet instead of HashSet so that the iteration order will be deterministic across different JVM versions or vendors, thus making the test more stable.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] StephanEwen commented on issue #11181:
[FLINK-16230][tests]Use LinkedHashSet instead of HashSet
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on issue #11181: [FLINK-16230][tests]Use LinkedHashSet instead of HashSet
URL: https://github.com/apache/flink/pull/11181#issuecomment-591351773
I think the right fix for that is to update the `DeeplyEqualsChecker` method to not treat all iterables the same, but to differentiate between Lists (orders) and other collections (like Sets).
@dawidwys can maybe provide more background.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] StephanEwen edited a comment on issue #11181:
[FLINK-16230][tests]Use LinkedHashSet instead of HashSet
Posted by GitBox <gi...@apache.org>.
StephanEwen edited a comment on issue #11181: [FLINK-16230][tests]Use LinkedHashSet instead of HashSet
URL: https://github.com/apache/flink/pull/11181#issuecomment-591351773
I think the right fix for that is to update the `DeeplyEqualsChecker` method to not treat all iterables the same, but to differentiate between Lists (ordered) and other collections (like Sets).
@dawidwys can maybe provide more background.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11181:
[FLINK-16230][tests]Use LinkedHashSet instead of HashSet
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11181: [FLINK-16230][tests]Use LinkedHashSet instead of HashSet
URL: https://github.com/apache/flink/pull/11181#issuecomment-589919323
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1adaf381144df070b76f311652607fe295842863",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150128180",
"triggerID" : "1adaf381144df070b76f311652607fe295842863",
"triggerType" : "PUSH"
}, {
"hash" : "6f3bc9cbe941d095afda5455e7d70a428cf79e29",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6f3bc9cbe941d095afda5455e7d70a428cf79e29",
"triggerType" : "PUSH"
}, {
"hash" : "38c3fcdbc15a68c2f70c1c34c22fcf81299933c2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "38c3fcdbc15a68c2f70c1c34c22fcf81299933c2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1adaf381144df070b76f311652607fe295842863 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150128180)
* 6f3bc9cbe941d095afda5455e7d70a428cf79e29 UNKNOWN
* 38c3fcdbc15a68c2f70c1c34c22fcf81299933c2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11181:
[FLINK-16230][tests]Use LinkedHashSet instead of HashSet
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11181: [FLINK-16230][tests]Use LinkedHashSet instead of HashSet
URL: https://github.com/apache/flink/pull/11181#issuecomment-589919323
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1adaf381144df070b76f311652607fe295842863",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150128180",
"triggerID" : "1adaf381144df070b76f311652607fe295842863",
"triggerType" : "PUSH"
}, {
"hash" : "6f3bc9cbe941d095afda5455e7d70a428cf79e29",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6f3bc9cbe941d095afda5455e7d70a428cf79e29",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1adaf381144df070b76f311652607fe295842863 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150128180)
* 6f3bc9cbe941d095afda5455e7d70a428cf79e29 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11181:
[FLINK-16230][tests]Use LinkedHashSet instead of HashSet
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11181: [FLINK-16230][tests]Use LinkedHashSet instead of HashSet
URL: https://github.com/apache/flink/pull/11181#issuecomment-589919323
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1adaf381144df070b76f311652607fe295842863",
"status" : "DELETED",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150128180",
"triggerID" : "1adaf381144df070b76f311652607fe295842863",
"triggerType" : "PUSH"
}, {
"hash" : "6f3bc9cbe941d095afda5455e7d70a428cf79e29",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6f3bc9cbe941d095afda5455e7d70a428cf79e29",
"triggerType" : "PUSH"
}, {
"hash" : "38c3fcdbc15a68c2f70c1c34c22fcf81299933c2",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151160491",
"triggerID" : "38c3fcdbc15a68c2f70c1c34c22fcf81299933c2",
"triggerType" : "PUSH"
}, {
"hash" : "38c3fcdbc15a68c2f70c1c34c22fcf81299933c2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5770",
"triggerID" : "38c3fcdbc15a68c2f70c1c34c22fcf81299933c2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6f3bc9cbe941d095afda5455e7d70a428cf79e29 UNKNOWN
* 38c3fcdbc15a68c2f70c1c34c22fcf81299933c2 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/151160491) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5770)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dawidwys commented on issue #11181: [FLINK-16230][tests]Use
LinkedHashSet instead of HashSet
Posted by GitBox <gi...@apache.org>.
dawidwys commented on issue #11181: [FLINK-16230][tests]Use LinkedHashSet instead of HashSet
URL: https://github.com/apache/flink/pull/11181#issuecomment-591442453
Hi @cpugputpu.
I agree with @StephanEwen that we should rather adjust the `DeeplyEqualsChecker`. I wonder though if it would make more sense to actually remove the branches for `Iterable` and `Row`.
It might have been a mistake to add those very specific cases into the general equality checker.
I think it was unnecessary to unify that deep equality check for all `Iterables` cause as far as I can tell we do not test serializing lists of arrays.
I tried removing those and run the tests and all the tests seem to pass.
I think we should rather assume that objects have properly implemented `equals` methods. If they do not, a more complex equality check can happen in that particular test. Therefore I think it still make sense to have the generic way of ingesting the `equalityChecker`, but we should not unify too many checkers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11181: [FLINK-16230][tests]Use
LinkedHashSet instead of HashSet
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11181: [FLINK-16230][tests]Use LinkedHashSet instead of HashSet
URL: https://github.com/apache/flink/pull/11181#issuecomment-589919323
<!--
Meta data
Hash:1adaf381144df070b76f311652607fe295842863 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:1adaf381144df070b76f311652607fe295842863
-->
## CI report:
* 1adaf381144df070b76f311652607fe295842863 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11181: [FLINK-16230][tests]Use
LinkedHashSet instead of HashSet
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11181: [FLINK-16230][tests]Use LinkedHashSet instead of HashSet
URL: https://github.com/apache/flink/pull/11181#issuecomment-589917192
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 1adaf381144df070b76f311652607fe295842863 (Sat Feb 22 04:29:35 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-16230).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11181:
[FLINK-16230][tests]Use LinkedHashSet instead of HashSet
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11181: [FLINK-16230][tests]Use LinkedHashSet instead of HashSet
URL: https://github.com/apache/flink/pull/11181#issuecomment-589919323
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1adaf381144df070b76f311652607fe295842863",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150128180",
"triggerID" : "1adaf381144df070b76f311652607fe295842863",
"triggerType" : "PUSH"
}, {
"hash" : "6f3bc9cbe941d095afda5455e7d70a428cf79e29",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6f3bc9cbe941d095afda5455e7d70a428cf79e29",
"triggerType" : "PUSH"
}, {
"hash" : "38c3fcdbc15a68c2f70c1c34c22fcf81299933c2",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/151160491",
"triggerID" : "38c3fcdbc15a68c2f70c1c34c22fcf81299933c2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1adaf381144df070b76f311652607fe295842863 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150128180)
* 6f3bc9cbe941d095afda5455e7d70a428cf79e29 UNKNOWN
* 38c3fcdbc15a68c2f70c1c34c22fcf81299933c2 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/151160491)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] cpugputpu commented on issue #11181:
[FLINK-16230][tests]Use LinkedHashSet instead of HashSet
Posted by GitBox <gi...@apache.org>.
cpugputpu commented on issue #11181: [FLINK-16230][tests]Use LinkedHashSet instead of HashSet
URL: https://github.com/apache/flink/pull/11181#issuecomment-592532190
Thanks for your valuable comments! Sorry for my delay. I will try to fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] cpugputpu closed pull request #11181:
[FLINK-16230][tests]Use LinkedHashSet instead of HashSet
Posted by GitBox <gi...@apache.org>.
cpugputpu closed pull request #11181: [FLINK-16230][tests]Use LinkedHashSet instead of HashSet
URL: https://github.com/apache/flink/pull/11181
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services