You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@groovy.apache.org by su...@apache.org on 2019/08/21 09:24:09 UTC

[groovy] 09/11: Only check the sign of compareTo()

This is an automated email from the ASF dual-hosted git repository.

sunlan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/groovy.git

commit 5543d61f27b35908837ad45346b78d676576bca7
Author: Bo Zhang <zh...@gmail.com>
AuthorDate: Sat Aug 17 19:30:32 2019 +0800

    Only check the sign of compareTo()
---
 src/main/java/groovy/util/PermutationGenerator.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/main/java/groovy/util/PermutationGenerator.java b/src/main/java/groovy/util/PermutationGenerator.java
index a9b68e2..59c59c0 100644
--- a/src/main/java/groovy/util/PermutationGenerator.java
+++ b/src/main/java/groovy/util/PermutationGenerator.java
@@ -75,7 +75,7 @@ public class PermutationGenerator<E> implements Iterator<List<E>> {
     }
 
     public boolean hasNext() {
-        return numLeft.compareTo(BigInteger.ZERO) == 1;
+        return numLeft.compareTo(BigInteger.ZERO) > 0;
     }
 
     /**