[GitHub] [arrow-datafusion] alamb commented on issue #6338: Document Window functions

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on issue #6338:
URL: https://github.com/apache/arrow-datafusion/issues/6338#issuecomment-1557964412

   Thanks @toppyy !
   
   > The issue states that the PR should "Note in the user guide that DataFusion supports window functions". Any ideas where exactly to mention this? I had a look and I didn't find a place that felt suitable.
   
   Perhaps we can add a new `Window Functions` page, following the model of `Aggregate Functions`?
   
   <img width="1299" alt="Screenshot 2023-05-22 at 4 42 29 PM" src="https://github.com/apache/arrow-datafusion/assets/490673/d0b05f08-4ff1-42c8-96b8-d94155460761">
   
   > Also, I was on the fence about whether to describe the over-clause with each function as it seems repetative. The alternative would be to described the syntax for window functions on top of the page once in a general form (ie. something like function(expr) over([partition by expr2] [order by expr3 [ asc | desc ][, …]])). Any thoughts?
   
   I think describing the OVER clause once in general rather than for each function makes much more sense.
   
   Perhaps we can take inspiration (and/or some of the text) from the postgres description: https://www.postgresql.org/docs/current/tutorial-window.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org