You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Yannick TANGUY (JIRA)" <ji...@apache.org> on 2012/10/02 17:43:07 UTC
[jira] [Commented] (MATH-811) Improve event detection by selecting
g function slope
[ https://issues.apache.org/jira/browse/MATH-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467797#comment-13467797 ]
Yannick TANGUY commented on MATH-811:
-------------------------------------
Ok, I notice that it won't be commited in 3.1.
About the changes in evaluateStep, there are not so many differences. Maybe the new if/then/else could be merged with the previous one, but the criteria would become complex and mix two differents aspects.
> Improve event detection by selecting g function slope
> -----------------------------------------------------
>
> Key: MATH-811
> URL: https://issues.apache.org/jira/browse/MATH-811
> Project: Commons Math
> Issue Type: Improvement
> Affects Versions: 3.1
> Reporter: Yannick TANGUY
> Attachments: JIRA-811_slope_selection.patch, JIRA-811_slope_selection_V2.patch, JIRA-811_slope_selection_V3.patch, JIRA-811_slope_selection_V3_with_spaces.patch, JIRA-811_slope_selection_with_spaces.patch
>
>
> We would like to select g function slope in CommonsMath event detection feature.
> This would improve event detection for the final user (the possibility to ignore some events, and less computation time) and also correct a bug found while using OREKIT (see https://www.orekit.org/forge/issues/104) in our applications.
> The modification consists in adding a method (getSlopeSelection() : int) in EventHandler, and modifying one conditionnal in the method evaluateStep (class EventState).
> We can provide modified code and unitary tests for this feature.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira