You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/01/30 04:04:43 UTC
[kudu-CR] [thirdparty] fix sized-deallocation issue on OS X 10.11
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9159
Change subject: [thirdparty] fix sized-deallocation issue on OS X 10.11
......................................................................
[thirdparty] fix sized-deallocation issue on OS X 10.11
Fixed the issue of building gperftools 2.6.3 on OS X 10.11. Also,
updated the top-level CMakeLists.txt to enable or disable the sized
deallocation feature for Kudu binaries accordingly.
Change-Id: I12632df70137bf5aed8b44d613b08856a925d840
---
M CMakeLists.txt
M thirdparty/download-thirdparty.sh
A thirdparty/patches/gperftools-sized-alloc-build-fix.patch
3 files changed, 53 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/9159/1
--
To view, visit http://gerrit.cloudera.org:8080/9159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I12632df70137bf5aed8b44d613b08856a925d840
Gerrit-Change-Number: 9159
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [thirdparty] fix sized-deallocation issue on OS X 10.11
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9159 )
Change subject: [thirdparty] fix sized-deallocation issue on OS X 10.11
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/9159/1/CMakeLists.txt
File CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/9159/1/CMakeLists.txt@1093
PS1, Line 1093: execute_process(
is this now redundant with the above compiler version checks? ie if this succeeds, then why do we care what version it is?
http://gerrit.cloudera.org:8080/#/c/9159/1/thirdparty/download-thirdparty.sh
File thirdparty/download-thirdparty.sh:
http://gerrit.cloudera.org:8080/#/c/9159/1/thirdparty/download-thirdparty.sh@134
PS1, Line 134: patch -p1 < $TP_DIR/patches/gperftools-sized-alloc-build-fix.patch
did you file a bug upstream with gperftools for this?
--
To view, visit http://gerrit.cloudera.org:8080/9159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I12632df70137bf5aed8b44d613b08856a925d840
Gerrit-Change-Number: 9159
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 31 Jan 2018 01:37:40 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] fix sized-deallocation issue on OS X 10.11
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9159 )
Change subject: [thirdparty] fix sized-deallocation issue on OS X 10.11
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I12632df70137bf5aed8b44d613b08856a925d840
Gerrit-Change-Number: 9159
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 06 Feb 2018 08:01:07 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] fix sized-deallocation issue on OS X 10.11
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9159 )
Change subject: [thirdparty] fix sized-deallocation issue on OS X 10.11
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/9159/1/CMakeLists.txt
File CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/9159/1/CMakeLists.txt@1093
PS1, Line 1093: execute_process(
> is this now redundant with the above compiler version checks? ie if this su
Indeed. That's a good observation! Done.
http://gerrit.cloudera.org:8080/#/c/9159/1/thirdparty/download-thirdparty.sh
File thirdparty/download-thirdparty.sh:
http://gerrit.cloudera.org:8080/#/c/9159/1/thirdparty/download-thirdparty.sh@134
PS1, Line 134: patch -p1 < $TP_DIR/patches/gperftools-sized-alloc-build-fix.patch
> did you file a bug upstream with gperftools for this?
I filed the following issue at gperftools github repo: https://github.com/gperftools/gperftools/issues/954
--
To view, visit http://gerrit.cloudera.org:8080/9159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I12632df70137bf5aed8b44d613b08856a925d840
Gerrit-Change-Number: 9159
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 31 Jan 2018 21:15:39 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] fix sized-deallocation issue on OS X 10.11
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9159
to look at the new patch set (#2).
Change subject: [thirdparty] fix sized-deallocation issue on OS X 10.11
......................................................................
[thirdparty] fix sized-deallocation issue on OS X 10.11
Fixed the issue of building gperftools 2.6.3 on OS X 10.11. Also,
updated the top-level CMakeLists.txt to enable or disable the sized
deallocation feature for Kudu binaries accordingly.
Change-Id: I12632df70137bf5aed8b44d613b08856a925d840
---
M CMakeLists.txt
M thirdparty/download-thirdparty.sh
A thirdparty/patches/gperftools-sized-alloc-build-fix.patch
3 files changed, 49 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/9159/2
--
To view, visit http://gerrit.cloudera.org:8080/9159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I12632df70137bf5aed8b44d613b08856a925d840
Gerrit-Change-Number: 9159
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [thirdparty] fix sized-deallocation issue on OS X 10.11
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9159 )
Change subject: [thirdparty] fix sized-deallocation issue on OS X 10.11
......................................................................
Patch Set 1: Verified+1
unrelated breakage in KuduMetastorePlugin.java:
20:08:19 /home/jenkins-slave/workspace/kudu-master/3/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java:20: error: package com.google.common.annotations does not exist
20:08:19 import com.google.common.annotations.VisibleForTesting;
--
To view, visit http://gerrit.cloudera.org:8080/9159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I12632df70137bf5aed8b44d613b08856a925d840
Gerrit-Change-Number: 9159
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 30 Jan 2018 15:56:58 +0000
Gerrit-HasComments: No
[kudu-CR] [thirdparty] fix sized-deallocation issue on OS X 10.11
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9159 )
Change subject: [thirdparty] fix sized-deallocation issue on OS X 10.11
......................................................................
[thirdparty] fix sized-deallocation issue on OS X 10.11
Fixed the issue of building gperftools 2.6.3 on OS X 10.11. Also,
updated the top-level CMakeLists.txt to enable or disable the sized
deallocation feature for Kudu binaries accordingly.
Change-Id: I12632df70137bf5aed8b44d613b08856a925d840
Reviewed-on: http://gerrit.cloudera.org:8080/9159
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M CMakeLists.txt
M thirdparty/download-thirdparty.sh
A thirdparty/patches/gperftools-sized-alloc-build-fix.patch
3 files changed, 49 insertions(+), 7 deletions(-)
Approvals:
Kudu Jenkins: Verified
Todd Lipcon: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/9159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I12632df70137bf5aed8b44d613b08856a925d840
Gerrit-Change-Number: 9159
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [thirdparty] fix sized-deallocation issue on OS X 10.11
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/9159 )
Change subject: [thirdparty] fix sized-deallocation issue on OS X 10.11
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/9159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I12632df70137bf5aed8b44d613b08856a925d840
Gerrit-Change-Number: 9159
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>