You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2018/12/20 02:35:36 UTC

[GitHub] cloud-fan commented on issue #23208: [SPARK-25530][SQL] data source v2 API refactor (batch write)

cloud-fan commented on issue #23208: [SPARK-25530][SQL] data source v2 API refactor (batch write)
URL: https://github.com/apache/spark/pull/23208#issuecomment-448837287
 
 
   > but it affects the API because it may change the structure of the builder or may be a reason to use a different pattern.
   
   According to the dicussion in the doc, seems you are challenging the current streaming engine in Spark. I don't think we should block the API refactor because of it. If we do need to change something fundamental in the streaming engine, that's a lot of work and it doesn't matter if the API refactor is done before or after it.
   
   > can you put the pseudocode for Spark's invocation sequence
   
   Sure, I'll follow the read  side doc and put it in the write side doc

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org