You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2023/01/13 17:06:21 UTC
[Bug 66421] New: Setting LDAPConnectionPoolTTL to -1 (default value) prevents apache to start
https://bz.apache.org/bugzilla/show_bug.cgi?id=66421
Bug ID: 66421
Summary: Setting LDAPConnectionPoolTTL to -1 (default value)
prevents apache to start
Product: Apache httpd-2
Version: 2.4.54
Hardware: PC
OS: Linux
Status: NEW
Severity: minor
Priority: P2
Component: mod_ldap
Assignee: bugs@httpd.apache.org
Reporter: bzapache@nailyk.fr
Target Milestone: ---
With the following configuration, Apache 2.4.54 (self built with OpenSSL 1.1.1s
does not start :
----
LoadModule ldap_module mod_ldap.so
LoadModule authz_ldap_module mod_authnz_ldap.so
LDAPConnectionPoolTTL -1
----
and gives the error : "LDAPConnectionPoolTTL has wrong format"
From the documentation
https://httpd.apache.org/docs/2.4/mod/mod_ldap.html#ldapconnectionpoolttl :
The default value of -1, and any other negative value, allows connections of
any age to be reused.
Looking at the code, the function ap_timeout_parameter_parse cannot return a
negative value
(https://github.com/apache/httpd/blob/trunk/modules/ldap/util_ldap.c#L2825 &
https://github.com/apache/httpd/blob/2.4.54/server/util.c#L2656)
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 66421] Setting LDAPConnectionPoolTTL to -1 (default value) prevents apache to start
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66421
nailyk <bz...@nailyk.fr> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |bzapache@nailyk.fr
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 66421] Setting LDAPConnectionPoolTTL to -1 (default value) prevents apache to start
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66421
--- Comment #3 from nailyk <bz...@nailyk.fr> ---
Confirmed the patch you provided fix the issue. Apache is now starting.
Thank you very much !
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 66421] Setting LDAPConnectionPoolTTL to -1 (default value) prevents apache to start
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66421
--- Comment #1 from nailyk <bz...@nailyk.fr> ---
Created attachment 38464
--> https://bz.apache.org/bugzilla/attachment.cgi?id=38464&action=edit
Patch proposal for 2.4.54 LDAPConnectionPoolTTL=-1 fix v1
Not the ideal solution but it seems to work.
(Still testing but, at least, Apache is now starting)
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 66421] Setting LDAPConnectionPoolTTL to -1 (default value) prevents apache to start
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66421
Christophe JAILLET <ch...@wanadoo.fr> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
--- Comment #2 from Christophe JAILLET <ch...@wanadoo.fr> ---
Hi,
Maybe the (untested) patch below is enough.
Can you give it a try?
Index: util_ldap.c
===================================================================
--- util_ldap.c (révision 1906512)
+++ util_ldap.c (copie de travail)
@@ -2817,12 +2817,14 @@
void *dummy,
const char *val)
{
- apr_interval_time_t timeout;
+ apr_interval_time_t timeout = -1;
util_ldap_state_t *st =
(util_ldap_state_t *)ap_get_module_config(cmd->server->module_config,
&ldap_module);
- if (ap_timeout_parameter_parse(val, &timeout, "s") != APR_SUCCESS) {
+ /* Negative values mean AP_LDAP_CONNPOOL_INFINITE */
+ if (val[0] != '-' &&
+ ap_timeout_parameter_parse(val, &timeout, "s") != APR_SUCCESS) {
return "LDAPConnectionPoolTTL has wrong format";
}
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 66421] Setting LDAPConnectionPoolTTL to -1 (default value) prevents apache to start
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66421
Christophe JAILLET <ch...@wanadoo.fr> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |NEW
--- Comment #4 from Christophe JAILLET <ch...@wanadoo.fr> ---
Thanks for the feed-back.
Fixed in trunk in r1907024.
Proposed for 2.4.x backport in r1907025.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 66421] Setting LDAPConnectionPoolTTL to -1 (default value) prevents apache to start
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66421
Christophe JAILLET <ch...@wanadoo.fr> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #5 from Christophe JAILLET <ch...@wanadoo.fr> ---
This was backported in 2.4.x branch in r1908027 and is part of version 2.4.56.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org