You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "yichinzhu (via GitHub)" <gi...@apache.org> on 2023/08/24 02:21:32 UTC
[GitHub] [commons-lang] yichinzhu opened a new pull request, #1100: Fix ThresholdCircuitBreaker
yichinzhu opened a new pull request, #1100:
URL: https://github.com/apache/commons-lang/pull/1100
According to the document, checkState() should return `true` if the circuit breaker is currently closed。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix ThresholdCircuitBreaker [commons-lang]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #1100:
URL: https://github.com/apache/commons-lang/pull/1100#issuecomment-1751728164
Hi @yichinzhu
Thank you for the clarification, you are correct! :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix ThresholdCircuitBreaker [commons-lang]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #1100:
URL: https://github.com/apache/commons-lang/pull/1100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #1100: Fix ThresholdCircuitBreaker
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #1100:
URL: https://github.com/apache/commons-lang/pull/1100#issuecomment-1690899248
-1, the docs read "<strong>true</strong> means that the circuit breaker is currently open"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] yichinzhu commented on pull request #1100: Fix ThresholdCircuitBreaker
Posted by "yichinzhu (via GitHub)" <gi...@apache.org>.
yichinzhu commented on PR #1100:
URL: https://github.com/apache/commons-lang/pull/1100#issuecomment-1690917469
> -1, the docs read "**true** means that the circuit breaker is currently open"
The comments in CircuitBreaker.java shows that "The return value indicates whether the circuit breaker is now in state closed a value of true typically means that the current operation can continue." .
And EventCountCircuitBreaker also returns true for CLOSED state as an implementation
links:
https://github.com/apache/commons-lang/blob/2fb38b1bb76a0a33d72864c8e39b536bce6b39e7/src/main/java/org/apache/commons/lang3/concurrent/CircuitBreaker.java#L61-L68
https://github.com/apache/commons-lang/blob/2fb38b1bb76a0a33d72864c8e39b536bce6b39e7/src/main/java/org/apache/commons/lang3/concurrent/EventCountCircuitBreaker.java#L336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org