[GitHub] [beam] prodriguezdefino commented on a diff in pull request #21813: Enable configuration to avoid successfully written Table Row propagation as part of WriteResult for StreamingInserts

[GitBox <gi...@apache.org>]

prodriguezdefino commented on code in PR #21813:
URL: https://github.com/apache/beam/pull/21813#discussion_r920580029


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/WriteResult.java:
##########
@@ -151,7 +151,9 @@ public PCollection<TableDestination> getSuccessfulTableLoads() {
   public PCollection<TableRow> getSuccessfulInserts() {
     if (successfulInserts == null) {
       throw new IllegalStateException(
-          "Retrieving successful inserts is only supported for streaming inserts.");

Review Comment:
   Not as is, but possibly we should share the `Write.Method` to this object so it knows the context and create a message like `Retrieving successful inserts is only supported for streaming inserts (Write.Method currently as FILE_LOADS).`
   Would that help? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org