[jira] [Commented] (LOG4J2-195) log files in async module

["Ralph Goers (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LOG4J2-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625033#comment-13625033 ] 

Ralph Goers commented on LOG4J2-195:
------------------------------------

I applied the patch in revision 1465483. However, I had to comment out 1 line in FastRollingFileAppenderRolloverTest as it is failing with the stack trace below.  In addition all of the test classes and ClockFactory were missing Apache License headers so I added them. Finally, I noticed that when I generated the web site the async project has over 70 checkstyle errors.

Running org.apache.logging.log4j.async.appender.FastRollingFileAppenderRolloverTest
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.453 sec <<< FAILURE!
testRollover(org.apache.logging.log4j.async.appender.FastRollingFileAppenderRolloverTest)  Time elapsed: 0.397 sec  <<< FAILURE!
java.lang.AssertionError: No more lines
	at org.junit.Assert.fail(Assert.java:91)
	at org.junit.Assert.assertTrue(Assert.java:43)
	at org.junit.Assert.assertNull(Assert.java:549)
	at org.apache.logging.log4j.async.appender.FastRollingFileAppenderRolloverTest.testRollover(FastRollingFileAppenderRolloverTest.java:72)
                
> log files in async module
> -------------------------
>
>                 Key: LOG4J2-195
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-195
>             Project: Log4j 2
>          Issue Type: Bug
>            Reporter: Remko Popma
>         Attachments: LOG4J2-195.patch
>
>
> Created JIRA ticket for this so I can submit a patch:
> > Remko, 
> > 
> > I just noticed that the log4j-async project is creating log files in the root directory
> of the project. This is bad practice. Can you modify the tests so that all the log files are
> written under the target directory?
> > 
> > Ralph

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org