You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "madhawa-gunasekara (via GitHub)" <gi...@apache.org> on 2024/07/30 13:20:56 UTC
[PR] fix: httpc connection close [apisix]
madhawa-gunasekara opened a new pull request, #11450:
URL: https://github.com/apache/apisix/pull/11450
### Description
This will close httpc connection. We observed too many connections in activemq.
Fixes #11449
### Checklist
- [x] I have explained the need for this PR and the problem it solves
- [x] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: httpc connection close [apisix]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11450:
URL: https://github.com/apache/apisix/pull/11450#issuecomment-2564286259
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: httpc connection close [apisix]
Posted by "madhawa-gunasekara (via GitHub)" <gi...@apache.org>.
madhawa-gunasekara commented on code in PR #11450:
URL: https://github.com/apache/apisix/pull/11450#discussion_r1700283675
##########
apisix/plugins/authz-casdoor.lua:
##########
@@ -60,7 +61,7 @@ local function fetch_access_token(code, conf)
["Content-Type"] = "application/x-www-form-urlencoded"
}
})
-
+ connection_util.close_http_connection(client)
Review Comment:
+1 will remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: httpc connection close [apisix]
Posted by "zhoujiexiong (via GitHub)" <gi...@apache.org>.
zhoujiexiong commented on PR #11450:
URL: https://github.com/apache/apisix/pull/11450#issuecomment-2287691736
Ping @madhawa-gunasekara :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: httpc connection close [apisix]
Posted by "shreemaan-abhishek (via GitHub)" <gi...@apache.org>.
shreemaan-abhishek commented on PR #11450:
URL: https://github.com/apache/apisix/pull/11450#issuecomment-2259550761
great catch 🙏🏼 , could you please check if this bug exists in other plugins/places too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: httpc connection close [apisix]
Posted by "madhawa-gunasekara (via GitHub)" <gi...@apache.org>.
madhawa-gunasekara commented on PR #11450:
URL: https://github.com/apache/apisix/pull/11450#issuecomment-2370572679
@zhoujiexiong I did the changes.. please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: httpc connection close [apisix]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11450:
URL: https://github.com/apache/apisix/pull/11450#issuecomment-2613899431
This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: httpc connection close [apisix]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #11450: fix: httpc connection close
URL: https://github.com/apache/apisix/pull/11450
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: httpc connection close [apisix]
Posted by "shreemaan-abhishek (via GitHub)" <gi...@apache.org>.
shreemaan-abhishek commented on PR #11450:
URL: https://github.com/apache/apisix/pull/11450#issuecomment-2262605651
@madhawa-gunasekara, please avoid force pushing 🙂 I have told this before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: httpc connection close [apisix]
Posted by "zhoujiexiong (via GitHub)" <gi...@apache.org>.
zhoujiexiong commented on code in PR #11450:
URL: https://github.com/apache/apisix/pull/11450#discussion_r1699576819
##########
apisix/plugins/authz-casdoor.lua:
##########
@@ -60,7 +61,7 @@ local function fetch_access_token(code, conf)
["Content-Type"] = "application/x-www-form-urlencoded"
}
})
-
+ connection_util.close_http_connection(client)
Review Comment:
`request_uri` will close(sock) before returning, so this line is not necessary? The same is true elsewhere of the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: httpc connection close [apisix]
Posted by "madhawa-gunasekara (via GitHub)" <gi...@apache.org>.
madhawa-gunasekara commented on PR #11450:
URL: https://github.com/apache/apisix/pull/11450#issuecomment-2299445079
Hi @zhoujiexiong,
I was traveling, I will push the changes. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: httpc connection close [apisix]
Posted by "zhoujiexiong (via GitHub)" <gi...@apache.org>.
zhoujiexiong commented on PR #11450:
URL: https://github.com/apache/apisix/pull/11450#issuecomment-2295063289
Ping @madhawa-gunasekara
:D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: httpc connection close [apisix]
Posted by "madhawa-gunasekara (via GitHub)" <gi...@apache.org>.
madhawa-gunasekara commented on PR #11450:
URL: https://github.com/apache/apisix/pull/11450#issuecomment-2431288686
@zhoujiexiong Ping, any chance to look into this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org