You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2019/12/27 22:05:31 UTC
[GitHub] [trafficcontrol] ZugNZwang opened a new issue #4241: Internal
Server Error when updating user's password using /user/current endpoint
ZugNZwang opened a new issue #4241: Internal Server Error when updating user's password using /user/current endpoint
URL: https://github.com/apache/trafficcontrol/issues/4241
<!--
************ STOP!! ************
If this issue identifies a security vulnerability, DO NOT submit it! Instead, contact
the Apache Software Foundation Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
-->
<!--
- For *SUPPORT QUESTIONS*, use the
[Traffic Control slack channels](https://traffic-control-cdn.slack.com) or [Traffic Control mailing lists](http://trafficcontrol.apache.org/mailing_lists/).
- Before submitting, please **SEARCH GITHUB** for a similar issue or PR. -->
## I'm submitting a ...
<!-- (check all that apply with "[x]") -->
<!--- security vulnerability (STOP!! - see above)-->
- [X] bug report
- [ ] new feature / enhancement request
- [ ] improvement request (usability, performance, tech debt, etc.)
- [ ] other <!--(Please do not submit support requests here - see above)-->
## Traffic Control components affected ...
<!-- (check all that apply with "[x]") -->
- [ ] CDN in a Box
- [ ] Documentation
- [ ] Grove
- [ ] Traffic Control Client
- [ ] Traffic Monitor
- [X] Traffic Ops
- [ ] Traffic Ops ORT
- [ ] Traffic Portal
- [ ] Traffic Router
- [ ] Traffic Stats
- [ ] Traffic Vault
- [ ] unknown
## Current behavior:
<!-- Describe how the bug manifests / how the current features are insufficient. -->
When making a `PUT` request to `/user/current` with the following request body:
```
{
"user": {
"localPasswd": "newPassword"
}
}
```
The response returned is:
```
HTTP/1.1 500 Internal Server Error
{
"alerts": [
{
"text": "Internal Server Error",
"level": "error"
}
]
}
```
## Expected / new behavior:
<!-- Describe what the behavior would be without the bug / how the feature would improve Traffic Control -->
Should either allow to change password or block the request.
## Minimal reproduction of the problem with instructions:
<!--
If the current behavior is a bug or you can illustrate your feature request better with an example,
please provide the *STEPS TO REPRODUCE* and include the applicable TC version.
-->
## Anything else:
<!-- e.g. stacktraces, related issues, suggestions how to fix -->
Error log:
`Updating user: resetting password: pq: syntax error at or near "WHERE"`
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] ZugNZwang commented on issue #4241: Internal
Server Error when updating user's password using /user/current endpoint
Posted by GitBox <gi...@apache.org>.
ZugNZwang commented on issue #4241: Internal Server Error when updating user's password using /user/current endpoint
URL: https://github.com/apache/trafficcontrol/issues/4241#issuecomment-569721883
I was able to update multiple fields without having the entire user object in the request.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] mitchell852 commented on issue #4241: Internal
Server Error when updating user's password using /user/current endpoint
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on issue #4241: Internal Server Error when updating user's password using /user/current endpoint
URL: https://github.com/apache/trafficcontrol/issues/4241#issuecomment-569732986
> I was able to update multiple fields without having the entire user object in the request.
yep, that's because PUT /user/current is the one PUT (i think) that really acts like a PATCH.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] mitchell852 commented on issue #4241: Internal
Server Error when updating user's password using /user/current endpoint
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on issue #4241: Internal Server Error when updating user's password using /user/current endpoint
URL: https://github.com/apache/trafficcontrol/issues/4241#issuecomment-569790381
for some reason i think to update a password you have to send a) localPasswd and b) confirmLocalPasswd (which is odd) but regardless a 500 internal server error would not be the proper response obviously.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] mitchell852 commented on issue #4241: Internal
Server Error when updating user's password using /user/current endpoint
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on issue #4241: Internal Server Error when updating user's password using /user/current endpoint
URL: https://github.com/apache/trafficcontrol/issues/4241#issuecomment-569720600
Pretty sure the PUT requires the entire user object as it is a "replace" and not a "modify" in which case the api should required 400 bad request with a list of missing required fields.
However, maybe this is our one PUT that acts like a PATCH. @ocket8888 would know I believe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] ocket8888 commented on issue #4241: Internal
Server Error when updating user's password using /user/current endpoint
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on issue #4241: Internal Server Error when updating user's password using /user/current endpoint
URL: https://github.com/apache/trafficcontrol/issues/4241#issuecomment-569893769
You shouldn't need to send a `confirmLocalPasswd` I believe, I think that'd be a regression. But yes, this is the PATCH-y PUT.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] mitchell852 closed issue #4241: Internal Server
Error when updating user's password using /user/current endpoint
Posted by GitBox <gi...@apache.org>.
mitchell852 closed issue #4241: Internal Server Error when updating user's password using /user/current endpoint
URL: https://github.com/apache/trafficcontrol/issues/4241
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services