You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/25 08:54:01 UTC

[GitHub] [pulsar] lhotari opened a new issue #10360: Flaky-test: [test class].[test method]

lhotari opened a new issue #10360:
URL: https://github.com/apache/pulsar/issues/10360


   TransactionEndToEndTest is flaky. The txnMessageAckTest test method fails sporadically.
   
   example failure:
   ```
   [ERROR] txnMessageAckTest(org.apache.pulsar.client.impl.TransactionEndToEndTest)  Time elapsed: 12.439 s  <<< FAILURE!
   java.lang.AssertionError: did not expect [70:4] but found [70:4]
   	at org.testng.Assert.fail(Assert.java:99)
   	at org.testng.Assert.failEquals(Assert.java:1041)
   	at org.testng.Assert.assertNotEqualsImpl(Assert.java:147)
   	at org.testng.Assert.assertNotEquals(Assert.java:1531)
   	at org.testng.Assert.assertNotEquals(Assert.java:1535)
   	at org.apache.pulsar.client.impl.TransactionEndToEndTest.markDeletePositionCheck(TransactionEndToEndTest.java:603)
   	at org.apache.pulsar.client.impl.TransactionEndToEndTest.txnMessageAckTest(TransactionEndToEndTest.java:423)
   	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
   	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   	at java.lang.reflect.Method.invoke(Method.java:498)
   	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:132)
   	at org.testng.internal.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:45)
   	at org.testng.internal.InvokeMethodRunnable.call(InvokeMethodRunnable.java:73)
   	at org.testng.internal.InvokeMethodRunnable.call(InvokeMethodRunnable.java:11)
   	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
   	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
   	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
   	at java.lang.Thread.run(Thread.java:748)
   ```
   
   It seems that the condition logic in `markDeletePositionCheck` is flaky.
   https://github.com/apache/pulsar/blob/e0fefe2d49a0a644cbdade2850f2394d1f2d5841/pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndTest.java#L589-L606


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui closed issue #10360: Flaky-test: TransactionEndToEndTest.txnMessageAckTest

Posted by GitBox <gi...@apache.org>.
codelipenghui closed issue #10360:
URL: https://github.com/apache/pulsar/issues/10360


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui closed issue #10360: Flaky-test: TransactionEndToEndTest.txnMessageAckTest

Posted by GitBox <gi...@apache.org>.
codelipenghui closed issue #10360:
URL: https://github.com/apache/pulsar/issues/10360


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] lhotari commented on issue #10360: Flaky-test: TransactionEndToEndTest.txnMessageAckTest

Posted by GitBox <gi...@apache.org>.
lhotari commented on issue #10360:
URL: https://github.com/apache/pulsar/issues/10360#issuecomment-826286452


   @congbobo184 @gaoran10 PTAL, I wonder if the logic could be refactored to use Awaitility?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] lhotari commented on issue #10360: Flaky-test: TransactionEndToEndTest.txnMessageAckTest

Posted by GitBox <gi...@apache.org>.
lhotari commented on issue #10360:
URL: https://github.com/apache/pulsar/issues/10360#issuecomment-826286452


   @congbobo184 @gaoran10 PTAL, I wonder if the logic could be refactored to use Awaitility?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org