You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2014/10/17 11:10:24 UTC

[Bug 57105] New: under in web.xml only accept integer which doesn't follow spec

https://issues.apache.org/bugzilla/show_bug.cgi?id=57105

            Bug ID: 57105
           Summary: <buffer> under <jsp-property-group>  in web.xml only
                    accept integer which doesn't follow spec
           Product: Tomcat 8
           Version: 8.0.14
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Meta
          Assignee: dev@tomcat.apache.org
          Reporter: xuyijun@gmail.com

For example, I expected the following should be fine:
<jsp-property-group>
  <buffer>32kb</buffer>
</jsp-property-group>

BUT actually, it will cause start app fail.

If I change it to:
<buffer>32000</buffer>

It is accepted. BUT, jsp compile will FAIL!

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 57105] under in web.xml only accept integer which doesn't follow spec and cause jsp compile fail

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57105

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Mark Thomas <ma...@apache.org> ---
Thanks for the report. This has been fixed in 8.0.x for 8.0.15 onwards and in
7.0.x for 7.0.57 onwards.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 57105] under in web.xml only accept integer which doesn't follow spec and cause jsp compile fail

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57105

--- Comment #2 from Tommy Xu <xu...@gmail.com> ---
What I mean is when set 32kb in <buffer> in web.xml is ok, BUT when tomcat
start, it will throw Exception, because in source code, it parse it by calling 
Integer.valueOf(...) which is want to convert "32kb" into a integer.

Please consider it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 57105] under in web.xml only accept integer which doesn't follow spec and cause jsp compile fail

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57105

--- Comment #1 from Konstantin Kolinko <kn...@gmail.com> ---
The allowed values are "none" and <number>"kb".
It is verified in org.apache.jasper.compiler.PageInfo.setBufferValue()

1. The buffer size can also be specified via buffer attribute on @page
directive. The same code is used to verify both use cases. Thus no wonder that
the check happens in JSP compiler.


2. I would say that the better place to do verification is XSD schema,
jsp_2_3.xsd.

Unfortunately it is currently declared there just as type="javaee:string" with
no further constraints.

I think that to make changes there, it has to be raised with the specification
folks.

Note that validation of web.xml is only enabled if you are running in "strict
compliance" mode by setting a system property or setting xmlValidation="true"
on Context.
https://tomcat.apache.org/tomcat-8.0-doc/config/systemprops.html#Specifications


3. I does not really feels as a job for JSP engine to verify web.xml, and
Servlet engine has little interest in those effectively foreign settings.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 57105] under in web.xml only accept integer which doesn't follow spec and cause jsp compile fail

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57105

Tommy Xu <xu...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|<buffer> under              |<buffer> under
                   |<jsp-property-group>  in    |<jsp-property-group>  in
                   |web.xml only accept integer |web.xml only accept integer
                   |which doesn't follow spec   |which doesn't follow spec
                   |                            |and cause jsp compile fail

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org