[GitHub] [spark] jzhuge commented on a change in pull request #23848: [SPARK-26946][SQL] Identifiers for multi-catalog

[GitBox <gi...@apache.org>]

jzhuge commented on a change in pull request #23848: [SPARK-26946][SQL] Identifiers for multi-catalog
URL: https://github.com/apache/spark/pull/23848#discussion_r265234026
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/identifiers.scala
 ##########
 @@ -105,3 +105,15 @@ case class FunctionIdentifier(funcName: String, database: Option[String])
 object FunctionIdentifier {
   def apply(funcName: String): FunctionIdentifier = new FunctionIdentifier(funcName)
 }
+
+/**
+ * Catalog identifier.
+
+ * @param space Namespace in the catalog
+ * @param name Object name
+ */
+case class CatalogIdentifier(space: CatalogIdentifier.Namespace, name: String)
 
 Review comment:
   Yes, it is similar to table identifier.
   How about renaming `CatalogIdentifier` to `ObectIdentifier`?
   And redefines `CatalogIdentifier` as:
   ```
   CatalogIdentifier(catalog: Option[String], ident: ObectIdentifier)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org