You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2015/08/25 04:14:02 UTC
Re: Review Request 37622: Maintenance Primitives: Shutdown & remove
slave when maintenance is started.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37622/
-----------------------------------------------------------
(Updated Aug. 25, 2015, 2:14 a.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Changes
-------
Rebased.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44
src/tests/master_maintenance_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/37622/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 37622: Maintenance Primitives: Shutdown & remove
slave when maintenance is started.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37622/#review97413
-----------------------------------------------------------
Ship it!
Ship It!
- Guangya Liu
On 八月 26, 2015, 2:13 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37622/
> -----------------------------------------------------------
>
> (Updated 八月 26, 2015, 2:13 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44
> src/tests/master_maintenance_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/37622/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37622: Maintenance Primitives: Shutdown & remove
slave when maintenance is started.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37622/#review97555
-----------------------------------------------------------
Ship it!
src/master/http.cpp (line 1567)
<https://reviews.apache.org/r/37622/#comment153561>
Now that the endpoint is called `/machine/down`, should the message be set to something like:
"Operator initiated"? Or "Machine down"?
src/tests/master_maintenance_tests.cpp (lines 631 - 632)
<https://reviews.apache.org/r/37622/#comment153550>
The first `{` could be moved up a line.
- Joseph Wu
On Sept. 2, 2015, 12:33 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37622/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 12:33 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/http.cpp 94e97a2898106579434e8cdec04b7b0e130a810e
> src/tests/master_maintenance_tests.cpp fb8dca3757a9565d5eb5a69eed10aa34602bb15c
>
> Diff: https://reviews.apache.org/r/37622/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37622: Maintenance Primitives: Shutdown & remove
slave when maintenance is started.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37622/
-----------------------------------------------------------
(Updated Sept. 14, 2015, 1:08 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/master/http.cpp 73e8857833603cb0edb77c352f343070ee1b8c80
src/tests/master_maintenance_tests.cpp fb8dca3757a9565d5eb5a69eed10aa34602bb15c
Diff: https://reviews.apache.org/r/37622/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 37622: Maintenance Primitives: Shutdown & remove
slave when maintenance is started.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Sept. 14, 2015, 3:36 a.m., Benjamin Hindman wrote:
> > src/master/http.cpp, lines 1622-1624
> > <https://reviews.apache.org/r/37622/diff/5/?file=1071200#file1071200line1622>
> >
> > Why don't we want to send lost slave messages?
Sorry, I meant: why don't we want to let lost slave messages get sent in the normal flow? Why do we need/want to do it immediately and explicitly here?
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37622/#review98806
-----------------------------------------------------------
On Sept. 13, 2015, 8:34 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37622/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2015, 8:34 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/http.cpp 73e8857833603cb0edb77c352f343070ee1b8c80
> src/tests/master_maintenance_tests.cpp fb8dca3757a9565d5eb5a69eed10aa34602bb15c
>
> Diff: https://reviews.apache.org/r/37622/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37622: Maintenance Primitives: Shutdown & remove
slave when maintenance is started.
Posted by Joris Van Remoortere <jo...@gmail.com>.
> On Sept. 14, 2015, 3:36 a.m., Benjamin Hindman wrote:
> > src/master/http.cpp, lines 1622-1624
> > <https://reviews.apache.org/r/37622/diff/5/?file=1071200#file1071200line1622>
> >
> > Why don't we want to send lost slave messages?
>
> Benjamin Hindman wrote:
> Sorry, I meant: why don't we want to let lost slave messages get sent in the normal flow? Why do we need/want to do it immediately and explicitly here?
I've removed the explicit removal here and created JIRA MESOS-3420 to discuss the semantics further.
- Joris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37622/#review98806
-----------------------------------------------------------
On Sept. 14, 2015, 1:08 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37622/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2015, 1:08 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/http.cpp 73e8857833603cb0edb77c352f343070ee1b8c80
> src/tests/master_maintenance_tests.cpp fb8dca3757a9565d5eb5a69eed10aa34602bb15c
>
> Diff: https://reviews.apache.org/r/37622/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37622: Maintenance Primitives: Shutdown & remove
slave when maintenance is started.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37622/#review98806
-----------------------------------------------------------
src/master/http.cpp (lines 1622 - 1624)
<https://reviews.apache.org/r/37622/#comment155399>
Why don't we want to send lost slave messages?
- Benjamin Hindman
On Sept. 13, 2015, 8:34 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37622/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2015, 8:34 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/http.cpp 73e8857833603cb0edb77c352f343070ee1b8c80
> src/tests/master_maintenance_tests.cpp fb8dca3757a9565d5eb5a69eed10aa34602bb15c
>
> Diff: https://reviews.apache.org/r/37622/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37622: Maintenance Primitives: Shutdown & remove
slave when maintenance is started.
Posted by Joris Van Remoortere <jo...@gmail.com>.
> On Sept. 14, 2015, 1:53 a.m., Qian Zhang wrote:
> > src/master/http.cpp, line 1606
> > <https://reviews.apache.org/r/37622/diff/5/?file=1071200#file1071200line1606>
> >
> > s/machineInfos/machines
Nice catch! Will be fixed in updated review.
- Joris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37622/#review98792
-----------------------------------------------------------
On Sept. 13, 2015, 8:34 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37622/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2015, 8:34 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/http.cpp 73e8857833603cb0edb77c352f343070ee1b8c80
> src/tests/master_maintenance_tests.cpp fb8dca3757a9565d5eb5a69eed10aa34602bb15c
>
> Diff: https://reviews.apache.org/r/37622/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37622: Maintenance Primitives: Shutdown & remove
slave when maintenance is started.
Posted by Qian Zhang <zh...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37622/#review98792
-----------------------------------------------------------
src/master/http.cpp (line 1606)
<https://reviews.apache.org/r/37622/#comment155394>
s/machineInfos/machines
- Qian Zhang
On Sept. 14, 2015, 4:34 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37622/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2015, 4:34 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/http.cpp 73e8857833603cb0edb77c352f343070ee1b8c80
> src/tests/master_maintenance_tests.cpp fb8dca3757a9565d5eb5a69eed10aa34602bb15c
>
> Diff: https://reviews.apache.org/r/37622/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37622: Maintenance Primitives: Shutdown & remove
slave when maintenance is started.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37622/
-----------------------------------------------------------
(Updated Sept. 13, 2015, 8:34 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/master/http.cpp 73e8857833603cb0edb77c352f343070ee1b8c80
src/tests/master_maintenance_tests.cpp fb8dca3757a9565d5eb5a69eed10aa34602bb15c
Diff: https://reviews.apache.org/r/37622/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 37622: Maintenance Primitives: Shutdown & remove
slave when maintenance is started.
Posted by Joris Van Remoortere <jo...@gmail.com>.
> On Sept. 6, 2015, 8:14 a.m., Klaus Ma wrote:
> > src/master/http.cpp, line 1570
> > <https://reviews.apache.org/r/37622/diff/4/?file=1062535#file1062535line1570>
> >
> > Should be LostSlaveMessage?
We end up sending both. I've modified the comment to make this more clear. Thanks!
- Joris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37622/#review97884
-----------------------------------------------------------
On Sept. 2, 2015, 7:33 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37622/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 7:33 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/http.cpp 94e97a2898106579434e8cdec04b7b0e130a810e
> src/tests/master_maintenance_tests.cpp fb8dca3757a9565d5eb5a69eed10aa34602bb15c
>
> Diff: https://reviews.apache.org/r/37622/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37622: Maintenance Primitives: Shutdown & remove
slave when maintenance is started.
Posted by Klaus Ma <kl...@cguru.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37622/#review97884
-----------------------------------------------------------
src/master/http.cpp (line 1570)
<https://reviews.apache.org/r/37622/#comment153950>
Should be LostSlaveMessage?
- Klaus Ma
On Sept. 2, 2015, 7:33 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37622/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 7:33 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/http.cpp 94e97a2898106579434e8cdec04b7b0e130a810e
> src/tests/master_maintenance_tests.cpp fb8dca3757a9565d5eb5a69eed10aa34602bb15c
>
> Diff: https://reviews.apache.org/r/37622/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37622: Maintenance Primitives: Shutdown & remove
slave when maintenance is started.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37622/
-----------------------------------------------------------
(Updated Sept. 2, 2015, 7:33 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/master/http.cpp 94e97a2898106579434e8cdec04b7b0e130a810e
src/tests/master_maintenance_tests.cpp fb8dca3757a9565d5eb5a69eed10aa34602bb15c
Diff: https://reviews.apache.org/r/37622/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 37622: Maintenance Primitives: Shutdown & remove
slave when maintenance is started.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37622/
-----------------------------------------------------------
(Updated Aug. 26, 2015, 2:13 a.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44
src/tests/master_maintenance_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/37622/diff/
Testing
-------
Thanks,
Joris Van Remoortere