You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by jennschiffer <gi...@git.apache.org> on 2014/07/23 17:33:10 UTC
[GitHub] couchdb-fauxton pull request: 2276 api bar restyle
GitHub user jennschiffer opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/14
2276 api bar restyle
restyled the api bar to the tooltip style and added the copy button functionality :santa:
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jennschiffer/couchdb-fauxton 2276-api-bar-restyle
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/14.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14
----
commit e24ec343f310ffaf71f03d507d0d2f7aadf80714
Author: Jenn Schiffer <je...@pancaketheorem.com>
Date: 2014-07-21T21:28:03Z
Style API bar open tray
commit fc706ba504472a40c84d70ca703207debf0cfaa5
Author: Jenn Schiffer <je...@pancaketheorem.com>
Date: 2014-07-22T18:15:18Z
style and add icons to api url
commit b52c4d55622f676a011b1837efaa89eb807aa582
Author: Jenn Schiffer <je...@pancaketheorem.com>
Date: 2014-07-22T18:30:38Z
add copy url functionality to api-bar
commit 2187320de6b9650d65d67739d945dc884183afe1
Author: Jenn Schiffer <je...@pancaketheorem.com>
Date: 2014-07-22T20:51:26Z
flash input bg color on api url copy button click
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: 2276 api bar restyle
Posted by jennschiffer <gi...@git.apache.org>.
Github user jennschiffer closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: 2276 api bar restyle
Posted by deathbearbrown <gi...@git.apache.org>.
Github user deathbearbrown commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/14#issuecomment-49892086
+1 YAAAAY
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: 2276 api bar restyle
Posted by deathbearbrown <gi...@git.apache.org>.
Github user deathbearbrown commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/14#discussion_r15295190
--- Diff: app/addons/fauxton/base.js ---
@@ -297,6 +296,21 @@ function(app, FauxtonAPI, resizeColumns) {
this.endpoint = endpoint[0];
this.documentation = endpoint[1];
this.render();
+ },
+ afterRender: function(){
+ ZeroClipboard.config({ moviePath: "/assets/js/plugins/zeroclipboard/ZeroClipboard.swf" });
+ var client = new ZeroClipboard(this.$(".copy-url"));
+ client.on("load", function(e){
+ var $apiInput = $('#api-navbar input');
+ var copyURLTimer;
+ client.on("mouseup", function(e){
+ $apiInput.css("background-color","#aaa");
+ clearTimeout(copyURLTimer);
--- End diff --
this breaks the linter (this is a test, Jenn already knows) hi
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: 2276 api bar restyle
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/14#issuecomment-50917156
@jennschiffer can you close the PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: 2276 api bar restyle
Posted by deathbearbrown <gi...@git.apache.org>.
Github user deathbearbrown commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/14#issuecomment-50281442
yeah I already merged it. Jenn is working with me on fauxton for the next few weeks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: 2276 api bar restyle
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/14#issuecomment-50279848
+1 great work!
I think this landed as f978779e904b48c7a079cb3d31f2d37d3b40bcf4 on master, isn't it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: 2276 api bar restyle
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/14#issuecomment-50286094
:yellow_heart:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---