[GitHub] [kafka] C0urante commented on a diff in pull request #14194: KAFKA-15336: Add ServiceLoader Javadocs for Connect plugins

["C0urante (via GitHub)" <gi...@apache.org>]

C0urante commented on code in PR #14194:
URL: https://github.com/apache/kafka/pull/14194#discussion_r1291736381


##########
connect/api/src/main/java/org/apache/kafka/connect/sink/SinkConnector.java:
##########
@@ -23,6 +23,9 @@
 
 /**
  * SinkConnectors implement the Connector interface to send Kafka data to another system.
+ * <p>Kafka Connect discovers extensions of this class using the Java {@link java.util.ServiceLoader} mechanism.

Review Comment:
   Someone may see that their connector is loaded correctly by an older Connect worker and devalue this note because it appears to be inaccurate.
   
   Perhaps something like "Newer versions of Kafka Connect discover...", or "Depending on the version and configuration of your Kafka Connect worker, extensions of this class may only be discoverable via the Java `ServiceLoader` mechanism"?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org