[GitHub] [apisix] spacewander commented on a diff in pull request #8275: refactor: remove if statement in nginx.conf

[GitBox <gi...@apache.org>]

spacewander commented on code in PR #8275:
URL: https://github.com/apache/apisix/pull/8275#discussion_r1062128762


##########
apisix/core/ctx.lua:
##########
@@ -201,6 +201,7 @@ do
         var_x_forwarded_proto = true,
         var_x_forwarded_port  = true,
         var_x_forwarded_host  = true,
+        var_x_forwarded_for  = true,

Review Comment:
   Bad indent



##########
apisix/init.lua:
##########
@@ -267,6 +267,17 @@ local function set_upstream_headers(api_ctx, picked_server)
         api_ctx.var.var_x_forwarded_host = x_forwarded_host
     end
 
+    local x_forwarded_for = api_ctx.var.http_x_forwarded_for

Review Comment:
   Would be better to use http://nginx.org/en/docs/http/ngx_http_proxy_module.html#var_proxy_add_x_forwarded_for directly?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org