You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2016/07/20 20:54:29 UTC

svn commit: r1753609 - in /pdfbox/branches/2.0: examples/src/main/java/org/apache/pdfbox/examples/signature/CreateVisibleSignature.java pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/visible/PDFTemplateCreator.java

Author: tilman
Date: Wed Jul 20 20:54:28 2016
New Revision: 1753609

URL: http://svn.apache.org/viewvc?rev=1753609&view=rev
Log:
PDFBOX-3017: remove call that has no effect, add a TODO for later

Modified:
    pdfbox/branches/2.0/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateVisibleSignature.java
    pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/visible/PDFTemplateCreator.java

Modified: pdfbox/branches/2.0/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateVisibleSignature.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateVisibleSignature.java?rev=1753609&r1=1753608&r2=1753609&view=diff
==============================================================================
--- pdfbox/branches/2.0/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateVisibleSignature.java (original)
+++ pdfbox/branches/2.0/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateVisibleSignature.java Wed Jul 20 20:54:28 2016
@@ -56,7 +56,7 @@ public class CreateVisibleSignature exte
             throws IOException
     {
         visibleSignDesigner = new PDVisibleSignDesigner(filename, imageStream, page);
-        visibleSignDesigner.xAxis(x).yAxis(y).zoom(zoomPercent).signatureFieldName("signature");
+        visibleSignDesigner.xAxis(x).yAxis(y).zoom(zoomPercent);
     }
     
     public void setVisibleSignatureProperties(String name, String location, String reason, int preferredSize, 

Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/visible/PDFTemplateCreator.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/visible/PDFTemplateCreator.java?rev=1753609&r1=1753608&r2=1753609&view=diff
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/visible/PDFTemplateCreator.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/digitalsignature/visible/PDFTemplateCreator.java Wed Jul 20 20:54:28 2016
@@ -98,6 +98,10 @@ public class PDFTemplateCreator
         PDSignatureField pdSignatureField = pdfStructure.getSignatureField();
         
         // create signature
+        //TODO 
+        // The line below has no effect with the CreateVisibleSignature example. 
+        // The signature field is needed as a "holder" for the /AP tree, 
+        // but the /P and /V PDSignatureField entries are ignored by PDDocument.addSignature
         pdfBuilder.createSignature(pdSignatureField, page, properties.getSignatureFieldName());
        
         // that is /AcroForm/DR entry