You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@groovy.apache.org by "Jochen Theodorou (JIRA)" <ji...@apache.org> on 2017/01/05 22:40:59 UTC

[jira] [Commented] (GROOVY-8038) Change BaseTemplate private methods to protected

    [ https://issues.apache.org/jira/browse/GROOVY-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15802761#comment-15802761 ] 

Jochen Theodorou commented on GROOVY-8038:
------------------------------------------

for writeIdent and createWriter, why not work with writeTo and DelegatingIdentWriter? And in case of forkModel you could work with layout.

> Change BaseTemplate private methods to protected
> ------------------------------------------------
>
>                 Key: GROOVY-8038
>                 URL: https://issues.apache.org/jira/browse/GROOVY-8038
>             Project: Groovy
>          Issue Type: Improvement
>          Components: Templating
>    Affects Versions: 2.4.7
>            Reporter: Sinuhé
>            Priority: Minor
>
> *groovy.text.markup.BaseTemplate* is a good candidate for extending it with custom methods. The problem is that common methods such as *createWriter()*, *forkModel()*, *writeIndent()* should be accessible by extended class. For simplicity, I suggest to change all current private methods to protected.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)