You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by John Keyes <jb...@mac.com> on 2002/10/19 23:31:01 UTC
[general] checkstyle report
Hi all,
I would be interested to hear people's opinions on the resolution
of checkstyle's error reporting. There are two options, one is to
correct the code style so it conforms to the checkstyle settings,
the other is to modify the settings to be less stringent.
IMO, it would be great to have a common style across commons.
I do think there would be opposition if this became a requirement
though so I think relaxing the checkstyle properties is probably
the way to go.
What do others think?
-John K
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [general] checkstyle report
Posted by Stephen Colebourne <sc...@btopenworld.com>.
I would certainly support setting these two things at the commons level. But
beyond that I would reckon that sticking with the checkstyle defaults is
about right. Over time, I reckon the projects will slowly fall into line.
Stephen
----- Original Message -----
From: "John Keyes" <jb...@mac.com>
To: "Jakarta Commons Developers List" <co...@jakarta.apache.org>
Sent: Saturday, October 19, 2002 11:54 PM
Subject: Re: [general] checkstyle report
> I know about how to fix these but what I was asking was
> was a more general topic. As a good deal of the commons
> projects inherit the POM from the CVS root I was wondering
> if it would be a good idea to have a the checkstyle properties
> set at this level also so all of the 'mavenized' projects pick
> up the same settings.
>
> I think this mail is perhaps a bit more coherent ;)
>
> -John K
>
> On Saturday, Oct 19, 2002, at 23:47 Europe/Dublin, Stephen Colebourne
> wrote:
>
> > On lang, changing the line length to 120 helped a lot. Also, I don't
> > know if
> > maven is on checkstyle 2.4, but if so it has a setting to deal with
> > RuntimeException throws clauses in javadoc correctly which should be
> > set
> >
> > Stephen
> >
> > ----- Original Message -----
> > From: "John Keyes" <jb...@mac.com>
> > To: "Jakarta Commons Developers List" <co...@jakarta.apache.org>
> > Sent: Saturday, October 19, 2002 11:29 PM
> > Subject: Re: [general] checkstyle report
> >
> >
> >> Yeap I'm on about the maven checkstyle report.
> >> -John K
> >>
> >> On Saturday, Oct 19, 2002, at 23:24 Europe/Dublin, Stephen Colebourne
> >> wrote:
> >>
> >>> Are you talking about the maven checkstyle report? Or a specific
> >>> projects?
> >>> Stephen
> >>>
> >>> ----- Original Message -----
> >>> From: "John Keyes" <jb...@mac.com>
> >>>> I would be interested to hear people's opinions on the resolution
> >>>> of checkstyle's error reporting. There are two options, one is to
> >>>> correct the code style so it conforms to the checkstyle settings,
> >>>> the other is to modify the settings to be less stringent.
> >>>>
> >>>> IMO, it would be great to have a common style across commons.
> >>>> I do think there would be opposition if this became a requirement
> >>>> though so I think relaxing the checkstyle properties is probably
> >>>> the way to go.
> >>>>
> >>>> What do others think?
> >>>>
> >>>> -John K
> >>>>
> >>>>
> >>>> --
> >>>> To unsubscribe, e-mail:
> >>> <ma...@jakarta.apache.org>
> >>>> For additional commands, e-mail:
> >>> <ma...@jakarta.apache.org>
> >>>>
> >>>
> >>>
> >>> --
> >>> To unsubscribe, e-mail:
> >>> <ma...@jakarta.apache.org>
> >>> For additional commands, e-mail:
> >>> <ma...@jakarta.apache.org>
> >>>
> >>
> >>
> >> --
> >> To unsubscribe, e-mail:
> > <ma...@jakarta.apache.org>
> >> For additional commands, e-mail:
> > <ma...@jakarta.apache.org>
> >>
> >
> >
> > --
> > To unsubscribe, e-mail:
> > <ma...@jakarta.apache.org>
> > For additional commands, e-mail:
> > <ma...@jakarta.apache.org>
> >
>
>
> --
> To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
> For additional commands, e-mail:
<ma...@jakarta.apache.org>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [general] checkstyle report
Posted by Steve Downey <st...@netfolio.com>.
I don't see why not. If a component needs some differences for their project,
they can change the inherited settings, nu?
And if a component just has internal inconsistencies, and no checkstyle
settings will quiesce the thing, then that's a problem that should be
addressed in the source, not the style checker.
On Saturday 19 October 2002 06:54 pm, John Keyes wrote:
> I know about how to fix these but what I was asking was
> was a more general topic. As a good deal of the commons
> projects inherit the POM from the CVS root I was wondering
> if it would be a good idea to have a the checkstyle properties
> set at this level also so all of the 'mavenized' projects pick
> up the same settings.
>
> I think this mail is perhaps a bit more coherent ;)
>
> -John K
>
> On Saturday, Oct 19, 2002, at 23:47 Europe/Dublin, Stephen Colebourne
>
> wrote:
> > On lang, changing the line length to 120 helped a lot. Also, I don't
> > know if
> > maven is on checkstyle 2.4, but if so it has a setting to deal with
> > RuntimeException throws clauses in javadoc correctly which should be
> > set
> >
> > Stephen
> >
> > ----- Original Message -----
> > From: "John Keyes" <jb...@mac.com>
> > To: "Jakarta Commons Developers List" <co...@jakarta.apache.org>
> > Sent: Saturday, October 19, 2002 11:29 PM
> > Subject: Re: [general] checkstyle report
> >
> >> Yeap I'm on about the maven checkstyle report.
> >> -John K
> >>
> >> On Saturday, Oct 19, 2002, at 23:24 Europe/Dublin, Stephen Colebourne
> >>
> >> wrote:
> >>> Are you talking about the maven checkstyle report? Or a specific
> >>> projects?
> >>> Stephen
> >>>
> >>> ----- Original Message -----
> >>> From: "John Keyes" <jb...@mac.com>
> >>>
> >>>> I would be interested to hear people's opinions on the resolution
> >>>> of checkstyle's error reporting. There are two options, one is to
> >>>> correct the code style so it conforms to the checkstyle settings,
> >>>> the other is to modify the settings to be less stringent.
> >>>>
> >>>> IMO, it would be great to have a common style across commons.
> >>>> I do think there would be opposition if this became a requirement
> >>>> though so I think relaxing the checkstyle properties is probably
> >>>> the way to go.
> >>>>
> >>>> What do others think?
> >>>>
> >>>> -John K
> >>>>
> >>>>
> >>>> --
> >>>> To unsubscribe, e-mail:
> >>>
> >>> <ma...@jakarta.apache.org>
> >>>
> >>>> For additional commands, e-mail:
> >>>
> >>> <ma...@jakarta.apache.org>
> >>>
> >>>
> >>>
> >>> --
> >>> To unsubscribe, e-mail:
> >>> <ma...@jakarta.apache.org>
> >>> For additional commands, e-mail:
> >>> <ma...@jakarta.apache.org>
> >>
> >> --
> >> To unsubscribe, e-mail:
> >
> > <ma...@jakarta.apache.org>
> >
> >> For additional commands, e-mail:
> >
> > <ma...@jakarta.apache.org>
> >
> >
> >
> > --
> > To unsubscribe, e-mail:
> > <ma...@jakarta.apache.org>
> > For additional commands, e-mail:
> > <ma...@jakarta.apache.org>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [general] checkstyle report
Posted by John Keyes <jb...@mac.com>.
I know about how to fix these but what I was asking was
was a more general topic. As a good deal of the commons
projects inherit the POM from the CVS root I was wondering
if it would be a good idea to have a the checkstyle properties
set at this level also so all of the 'mavenized' projects pick
up the same settings.
I think this mail is perhaps a bit more coherent ;)
-John K
On Saturday, Oct 19, 2002, at 23:47 Europe/Dublin, Stephen Colebourne
wrote:
> On lang, changing the line length to 120 helped a lot. Also, I don't
> know if
> maven is on checkstyle 2.4, but if so it has a setting to deal with
> RuntimeException throws clauses in javadoc correctly which should be
> set
>
> Stephen
>
> ----- Original Message -----
> From: "John Keyes" <jb...@mac.com>
> To: "Jakarta Commons Developers List" <co...@jakarta.apache.org>
> Sent: Saturday, October 19, 2002 11:29 PM
> Subject: Re: [general] checkstyle report
>
>
>> Yeap I'm on about the maven checkstyle report.
>> -John K
>>
>> On Saturday, Oct 19, 2002, at 23:24 Europe/Dublin, Stephen Colebourne
>> wrote:
>>
>>> Are you talking about the maven checkstyle report? Or a specific
>>> projects?
>>> Stephen
>>>
>>> ----- Original Message -----
>>> From: "John Keyes" <jb...@mac.com>
>>>> I would be interested to hear people's opinions on the resolution
>>>> of checkstyle's error reporting. There are two options, one is to
>>>> correct the code style so it conforms to the checkstyle settings,
>>>> the other is to modify the settings to be less stringent.
>>>>
>>>> IMO, it would be great to have a common style across commons.
>>>> I do think there would be opposition if this became a requirement
>>>> though so I think relaxing the checkstyle properties is probably
>>>> the way to go.
>>>>
>>>> What do others think?
>>>>
>>>> -John K
>>>>
>>>>
>>>> --
>>>> To unsubscribe, e-mail:
>>> <ma...@jakarta.apache.org>
>>>> For additional commands, e-mail:
>>> <ma...@jakarta.apache.org>
>>>>
>>>
>>>
>>> --
>>> To unsubscribe, e-mail:
>>> <ma...@jakarta.apache.org>
>>> For additional commands, e-mail:
>>> <ma...@jakarta.apache.org>
>>>
>>
>>
>> --
>> To unsubscribe, e-mail:
> <ma...@jakarta.apache.org>
>> For additional commands, e-mail:
> <ma...@jakarta.apache.org>
>>
>
>
> --
> To unsubscribe, e-mail:
> <ma...@jakarta.apache.org>
> For additional commands, e-mail:
> <ma...@jakarta.apache.org>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [general] checkstyle report
Posted by Stephen Colebourne <sc...@btopenworld.com>.
On lang, changing the line length to 120 helped a lot. Also, I don't know if
maven is on checkstyle 2.4, but if so it has a setting to deal with
RuntimeException throws clauses in javadoc correctly which should be set
Stephen
----- Original Message -----
From: "John Keyes" <jb...@mac.com>
To: "Jakarta Commons Developers List" <co...@jakarta.apache.org>
Sent: Saturday, October 19, 2002 11:29 PM
Subject: Re: [general] checkstyle report
> Yeap I'm on about the maven checkstyle report.
> -John K
>
> On Saturday, Oct 19, 2002, at 23:24 Europe/Dublin, Stephen Colebourne
> wrote:
>
> > Are you talking about the maven checkstyle report? Or a specific
> > projects?
> > Stephen
> >
> > ----- Original Message -----
> > From: "John Keyes" <jb...@mac.com>
> >> I would be interested to hear people's opinions on the resolution
> >> of checkstyle's error reporting. There are two options, one is to
> >> correct the code style so it conforms to the checkstyle settings,
> >> the other is to modify the settings to be less stringent.
> >>
> >> IMO, it would be great to have a common style across commons.
> >> I do think there would be opposition if this became a requirement
> >> though so I think relaxing the checkstyle properties is probably
> >> the way to go.
> >>
> >> What do others think?
> >>
> >> -John K
> >>
> >>
> >> --
> >> To unsubscribe, e-mail:
> > <ma...@jakarta.apache.org>
> >> For additional commands, e-mail:
> > <ma...@jakarta.apache.org>
> >>
> >
> >
> > --
> > To unsubscribe, e-mail:
> > <ma...@jakarta.apache.org>
> > For additional commands, e-mail:
> > <ma...@jakarta.apache.org>
> >
>
>
> --
> To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
> For additional commands, e-mail:
<ma...@jakarta.apache.org>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [general] checkstyle report
Posted by John Keyes <jb...@mac.com>.
Yeap I'm on about the maven checkstyle report.
-John K
On Saturday, Oct 19, 2002, at 23:24 Europe/Dublin, Stephen Colebourne
wrote:
> Are you talking about the maven checkstyle report? Or a specific
> projects?
> Stephen
>
> ----- Original Message -----
> From: "John Keyes" <jb...@mac.com>
>> I would be interested to hear people's opinions on the resolution
>> of checkstyle's error reporting. There are two options, one is to
>> correct the code style so it conforms to the checkstyle settings,
>> the other is to modify the settings to be less stringent.
>>
>> IMO, it would be great to have a common style across commons.
>> I do think there would be opposition if this became a requirement
>> though so I think relaxing the checkstyle properties is probably
>> the way to go.
>>
>> What do others think?
>>
>> -John K
>>
>>
>> --
>> To unsubscribe, e-mail:
> <ma...@jakarta.apache.org>
>> For additional commands, e-mail:
> <ma...@jakarta.apache.org>
>>
>
>
> --
> To unsubscribe, e-mail:
> <ma...@jakarta.apache.org>
> For additional commands, e-mail:
> <ma...@jakarta.apache.org>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [general] checkstyle report
Posted by Stephen Colebourne <sc...@btopenworld.com>.
Are you talking about the maven checkstyle report? Or a specific projects?
Stephen
----- Original Message -----
From: "John Keyes" <jb...@mac.com>
> I would be interested to hear people's opinions on the resolution
> of checkstyle's error reporting. There are two options, one is to
> correct the code style so it conforms to the checkstyle settings,
> the other is to modify the settings to be less stringent.
>
> IMO, it would be great to have a common style across commons.
> I do think there would be opposition if this became a requirement
> though so I think relaxing the checkstyle properties is probably
> the way to go.
>
> What do others think?
>
> -John K
>
>
> --
> To unsubscribe, e-mail:
<ma...@jakarta.apache.org>
> For additional commands, e-mail:
<ma...@jakarta.apache.org>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [general] checkstyle report
Posted by Michael Davey <Mi...@CodeRage.ORG>.
dion@multitask.com.au wrote:
> How about using Jalopy to fix the code up?
I wasn't even aware of Jalopy. I see it can even sort the ordering of methods
and fix license headers ;)
Can CVS be configured to use Jaolpy to fix the coding style automagically during
checkin? I'm not familiar with CVS server configuration, but I do notice that
the command-line plugin for Jalopy supports pipelining.
--
Michael
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [general] checkstyle report
Posted by di...@multitask.com.au.
John Keyes <jb...@mac.com> wrote on 20/10/2002 07:31:01 AM:
> Hi all,
>
> I would be interested to hear people's opinions on the resolution
> of checkstyle's error reporting. There are two options, one is to
> correct the code style so it conforms to the checkstyle settings,
> the other is to modify the settings to be less stringent.
>
> IMO, it would be great to have a common style across commons.
> I do think there would be opposition if this became a requirement
> though so I think relaxing the checkstyle properties is probably
> the way to go.
>
> What do others think?
How about using Jalopy to fix the code up?
>
> -John K
--
dIon Gillard, Multitask Consulting
Work: http://www.multitask.com.au
Developers: http://adslgateway.multitask.com.au/developers
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [general] checkstyle report
Posted by John Keyes <jb...@mac.com>.
>> Hi all,
>>
>> I would be interested to hear people's opinions on the resolution
>> of checkstyle's error reporting. There are two options, one is to
>> correct the code style so it conforms to the checkstyle settings,
>> the other is to modify the settings to be less stringent.
>
> Possibly a set of checkstyle settings could be made. We could classify
> different styles as 'Jon-style', 'Jason-style', 'Sun-style' and
> projects
> could use those styles.
Thats a good idea, we could have a styles dir at the commons level
that would store these styles. I'll record this idea.
-John K
- - - - - - - - - - - - - - - - - - - - - - -
Jakarta Commons CLI
http://jakarta.apache.org/commons/cli
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: [general] checkstyle report
Posted by Henri Yandell <ba...@generationjava.com>.
On Sat, 19 Oct 2002, John Keyes wrote:
> Hi all,
>
> I would be interested to hear people's opinions on the resolution
> of checkstyle's error reporting. There are two options, one is to
> correct the code style so it conforms to the checkstyle settings,
> the other is to modify the settings to be less stringent.
Possibly a set of checkstyle settings could be made. We could classify
different styles as 'Jon-style', 'Jason-style', 'Sun-style' and projects
could use those styles.
> IMO, it would be great to have a common style across commons.
> I do think there would be opposition if this became a requirement
> though so I think relaxing the checkstyle properties is probably
> the way to go.
It'd be wonderful. Now once you all agree to like my style [btw, George
Reese converted me to doing static before public and abstract before
public, none of you will mind will you?] then we can get to work :) ie)
snowball, texas, free-beer.
Relaxing the style seems a bit of a wimpy solution though :( So I like my
idea of having a set of commons-styles. ie) Create a few standards.
Possibly.
I think that's maybe a ice-patch, kentucky, 80% off beer though. So
probably not likely to work.
Hen
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>