You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by "hanicz (via GitHub)" <gi...@apache.org> on 2026/10/14 06:21:46 UTC
[PR] KNOX-3514: Login and logout faviocn and title branding [knox]
hanicz opened a new pull request, #1455:
URL: https://github.com/apache/knox/pull/1455
[KNOX-3514](https://issues.apache.org/jira/browse/KNOX-3514) - Make favicon and page title theme bound as well
## What changes were proposed in this pull request?
Make favicon and page title theme-bound on knoxauth login/logout pages
The knoxauth themes only swapped CSS, so themed login and logout pages still showed the default Knox favicon and "KnoxSSO" title in the browser tab.
This adds an optional `KNOX_THEME_BRANDING` map in `theme-config.js`, keyed by theme name, where each theme can set a title brand (replaces "KnoxSSO") and a favicon path. `knox-theme.js` applies them as the page head loads, so there's no flash of the old title/favicon. Themes without an entry keep the Knox defaults.
The bundled modern theme now shows "Apache Knox SSO - Sign In" / "Apache Knox SSO - Session Termination" and a new SVG favicon.
## How was this patch tested?
Tested locally the modern and default themes
## UI changes
<img width="1919" height="968" alt="Screenshot 2026-10-14 at 8 17 16" src="https://github.com/user-attachments/assets/f5eb5c8c-d176-41c2-bcbe-7ef0a44c8c4d" />
<img width="1909" height="962" alt="Screenshot 2026-10-14 at 8 17 34" src="https://github.com/user-attachments/assets/e946d72e-8e60-4aca-960f-95d36f347b0e" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KNOX-3514: Login and logout favicon and title branding [knox]
Posted by "hanicz (via GitHub)" <gi...@apache.org>.
hanicz merged PR #1455:
URL: https://github.com/apache/knox/pull/1455
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KNOX-3514: Login and logout favicon and title branding [knox]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1455:
URL: https://github.com/apache/knox/pull/1455#issuecomment-6165328281
## Test Results
4 files 4 suites 46s ⏱️
132 tests 132 ✅ 0 💤 0 ❌
150 runs 150 ✅ 0 💤 0 ❌
Results for commit 8c42bc37.
[test-results]:data:application/gzip;base64,H4sIAIVMz2oC/13MQQ7CIBCF4as0rF1QSlv0MganQzKxLYbCynh3p8Qiuvz+l7yncDTjJi6NPjViSxQLphRsJL/uHNi8xH1rO3XouiWA/3SnBydZgrM0/wQMwYdPCWnNn/2BclmV72N2dZhd/4FfFooMYUCrG3SjlspqxnRGY8fegWwHVA7RAXdtxOsNqX0JdwQBAAA=
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org