You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by "edmond-kk (via GitHub)" <gi...@apache.org> on 2024/03/05 02:44:33 UTC

Re: [PR] Use SampleBucketSplitStrategy for shard collection with hashed keys #2504 [flink-cdc]

edmond-kk commented on PR #2595:
URL: https://github.com/apache/flink-cdc/pull/2595#issuecomment-1977848126

   Is this judgment correct?
   `            if (!(isValidShardedCollection(collectionMetadata)
                       && isNotShardedByHash(collectionMetadata))) {
                   LOG.warn(
                           "Collection {} does not appear to be sharded, or shared by hash, fallback to SampleSplitter.",
                           collectionId);
                   return SampleBucketSplitStrategy.INSTANCE.split(splitContext);
               }`
   if collection is shard by range,the code will not enter this branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org