You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by to...@apache.org on 2019/06/19 07:11:23 UTC
[kudu] branch master updated (523ec8b -> c9a925b)
This is an automated email from the ASF dual-hosted git repository.
todd pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git.
from 523ec8b KUDU-2381: Optimize DeltaMemStore for case of no matching deltas.
new d0db4c4 [tablet_copy_client-test] fix compiler warning
new c9a925b DeltaPreparer: use vectors instead of deques
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
src/kudu/tablet/delta_store.h | 8 ++++----
src/kudu/tserver/tablet_copy_client-test.cc | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
[kudu] 02/02: DeltaPreparer: use vectors instead of deques
Posted by to...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
todd pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git
commit c9a925b1766faf5a77e0e56aaccd5923bc980530
Author: Todd Lipcon <to...@apache.org>
AuthorDate: Tue Jun 18 01:13:10 2019 -0700
DeltaPreparer: use vectors instead of deques
We had a few std::deque<>s in this class that seem like they could just
as well use vectors. Vectors are a simpler data structure, so may as
well use it instead.
Change-Id: I4161d1dfbf91294f36487da077baaa5a61dd014e
Reviewed-on: http://gerrit.cloudera.org:8080/13668
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
src/kudu/tablet/delta_store.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/kudu/tablet/delta_store.h b/src/kudu/tablet/delta_store.h
index b15e2f0..069600e 100644
--- a/src/kudu/tablet/delta_store.h
+++ b/src/kudu/tablet/delta_store.h
@@ -493,10 +493,10 @@ class DeltaPreparer : public PreparedDeltas {
// A row whose last relevant mutation was DELETE (or REINSERT).
//
- // These deques are disjoint; a row that was both deleted and reinserted will
+ // These lists are disjoint; a row that was both deleted and reinserted will
// not be in either.
- std::deque<rowid_t> deleted_;
- std::deque<rowid_t> reinserted_;
+ std::vector<rowid_t> deleted_;
+ std::vector<rowid_t> reinserted_;
// The deletion state of the row last processed by AddDelta().
//
@@ -515,7 +515,7 @@ class DeltaPreparer : public PreparedDeltas {
DeltaKey key;
Slice val;
};
- std::deque<PreparedDelta> prepared_deltas_;
+ std::vector<PreparedDelta> prepared_deltas_;
// State when prepared_for_ & PREPARED_FOR_SELECT
// ------------------------------------------------------------
[kudu] 01/02: [tablet_copy_client-test] fix compiler warning
Posted by to...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
todd pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git
commit d0db4c4cd36c1388e36576742cc7fe8c3adfcb77
Author: Alexey Serbin <as...@cloudera.com>
AuthorDate: Tue Jun 18 16:41:23 2019 -0700
[tablet_copy_client-test] fix compiler warning
Fixed compilation warning in TabletCopyClientTest:
src/kudu/tserver/tablet_copy_client-test.cc:149:16: \
warning: 'GenerateTestData' overrides a member function but \
is not marked 'override' [-Winconsistent-missing-override]
virtual void GenerateTestData() {
^
src/kudu/tserver/tablet_copy-test-base.h:113:16: \
note: overridden virtual function is here
virtual void GenerateTestData() {
^
1 warning generated.
This patch does not contain any functional modifications.
Change-Id: Ib0194589f7ff38a66dc2ae85ff02f8f9346b1db6
Reviewed-on: http://gerrit.cloudera.org:8080/13674
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
src/kudu/tserver/tablet_copy_client-test.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/kudu/tserver/tablet_copy_client-test.cc b/src/kudu/tserver/tablet_copy_client-test.cc
index 5dd9f4e..c24adb6 100644
--- a/src/kudu/tserver/tablet_copy_client-test.cc
+++ b/src/kudu/tserver/tablet_copy_client-test.cc
@@ -146,7 +146,7 @@ class TabletCopyClientTest : public TabletCopyTest {
Status CompareFileContents(const string& path1, const string& path2);
// Injection of 'supports_live_row_count' modifiers through polymorphic characteristic.
- virtual void GenerateTestData() {
+ void GenerateTestData() override {
Random rand(SeedRandom());
NO_FATALS(tablet_replica_->tablet_metadata()->
set_supports_live_row_count_for_tests(rand.Next() % 2));