[GitHub] [incubator-superset] rusackas opened a new pull request #8681: Only list tables in DB test if API returns them (which it doesn't)

[GitBox <gi...@apache.org>]

rusackas opened a new pull request #8681: Only list tables in DB test if API returns them (which it doesn't)
URL: https://github.com/apache/incubator-superset/pull/8681
 
 
   …ever will)
   
   ### CATEGORY
   
   Choose one
   
   - [X] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   I noticed that when you use the button to test a DB connection, the API just responds with "OK" and not a list of tables. That may be an issue worth exploring, or maybe it was changed for a good reason. In any case, there was some Javascript that was bugging out in trying to process/display a list of tables from that "OK" so I made this display logic conditional, such that it will only run if an array of tables is indeed returned. I doubt that will ever happen, but at least this PR kills the console error in any case.
   
   ### REVIEWERS
   @mistercrunch 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org