[GitHub] [airflow] potiuk commented on a diff in pull request #30718: Add a new arg for KPO to only delete the pod when it doesn't fail

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk commented on code in PR #30718:
URL: https://github.com/apache/airflow/pull/30718#discussion_r1246312134


##########
airflow/providers/amazon/provider.yaml:
##########
@@ -667,3 +667,6 @@ additional-extras:
   - name: aiobotocore
     dependencies:
       - aiobotocore[boto3]>=2.2.0
+  - name: cncf.kubernetes
+    dependencies:
+      - apache-airflow-providers-cncf-kubernetes>=8.0.0

Review Comment:
   I think `>=8.0.0` is fine, and we have to release those three packages together. There should be 8.0.0 release of cncf.kubernetes coming together with releasing of those two providers (the changes in cncf.kubernetes it brings are breaking, so that's expected to be bumped to 8.0.0.
   
   Comment: The "additional" dependencies are pretty special because they are mostly "informatory". Almost no-one will install `apache-airflow-providers-amazon[cncf.kubernetes]==8.3.0` - what is mainly the purpose of those is to be document the dependencies.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org