You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/10/25 04:09:32 UTC
[GitHub] [skywalking-swck] hanahmily opened a new pull request #40: Several improvements for 0.4.0 release
hanahmily opened a new pull request #40:
URL: https://github.com/apache/skywalking-swck/pull/40
* Bump up SkyWalking OAP to 8.8.1(latest)
* Update README.md laid in the binary package
* Add a docker build tool to the binary package where users can
build the docker image from binaries in the bin folder
* Update release document and bash script to insert "v" into
the git release tag.
Signed-off-by: Gao Hongtao <ha...@gmail.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] wu-sheng merged pull request #40: Several improvements for 0.4.0 release
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #40:
URL: https://github.com/apache/skywalking-swck/pull/40
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] wu-sheng commented on pull request #40: Several improvements for 0.4.0 release
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #40:
URL: https://github.com/apache/skywalking-swck/pull/40#issuecomment-950510804
SWCK didn't choose es6 or es7 before, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-swck] hanahmily commented on a change in pull request #40: Several improvements for 0.4.0 release
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #40:
URL: https://github.com/apache/skywalking-swck/pull/40#discussion_r735245534
##########
File path: apis/operator/v1alpha1/oapserver_webhook.go
##########
@@ -48,19 +48,7 @@ func (r *OAPServer) Default() {
image := r.Spec.Image
if image == "" {
- v := r.Spec.Version
- vTmpl := "apache/skywalking-oap-server:%s-%s"
- vES := "es6"
- for _, e := range r.Spec.Config {
- if e.Name != "SW_STORAGE" {
- continue
- }
- if e.Value == "elasticsearch7" {
- vES = "es7"
- }
- }
- image = fmt.Sprintf(vTmpl, v, vES)
- r.Spec.Image = image
+ r.Spec.Image = fmt.Sprintf("apache/skywalking-oap-server:%s", r.Spec.Version)
Review comment:
> SWCK didn't choose es6 or es7 before, right?
Yes, it did.
I updated the default image tag logic based on the newest 8.8.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org