[jira] [Commented] (MAPREDUCE-2103) task-controller shouldn't require o-r permissions

["Eli Collins (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154486#comment-13154486 ] 

Eli Collins commented on MAPREDUCE-2103:
----------------------------------------

{noformat}
     [exec] 
     [exec] -1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
     [exec]                         Please justify why no tests are needed for this patch.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec] 
     [exec]     -1 findbugs.  The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.
     [exec] 
     [exec] 
{noformat}

Existing test coverage is sufficient. Findbugs warnings are unrelated (filed HADOOP-7847). test-task-controller passes.
                
> task-controller shouldn't require o-r permissions
> -------------------------------------------------
>
>                 Key: MAPREDUCE-2103
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2103
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: task-controller
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Trivial
>         Attachments: mapreduce-2103-20x.patch, mapreduce-2103.txt, mapreduce-2103.txt
>
>
> The task-controller currently checks that "other" users don't have read permissions. This is unnecessary - we just need to make it's not executable. The debian policy manual explains it well:
> {quote}
> Setuid and setgid executables should be mode 4755 or 2755 respectively, and owned by the appropriate user or group. They should not be made unreadable (modes like 4711 or 2711 or even 4111); doing so achieves no extra security, because anyone can find the binary in the freely available Debian package; it is merely inconvenient. For the same reason you should not restrict read or execute permissions on non-set-id executables.
> Some setuid programs need to be restricted to particular sets of users, using file permissions. In this case they should be owned by the uid to which they are set-id, and by the group which should be allowed to execute them. They should have mode 4754; again there is no point in making them unreadable to those users who must not be allowed to execute them.
> {quote}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira