[jira] [Commented] (FLINK-10465) Jepsen: runit supervised sshd is stopped on tear down

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-10465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641817#comment-16641817 ] 

ASF GitHub Bot commented on FLINK-10465:
----------------------------------------

StefanRRichter commented on a change in pull request #6779: [FLINK-10465][tests] Do not stop sshd if it is supervised by runit.
URL: https://github.com/apache/flink/pull/6779#discussion_r223358568
 
 

 ##########
 File path: flink-jepsen/src/jepsen/flink/utils.clj
 ##########
 @@ -86,4 +86,7 @@
   []
   (info "Stop all supervised services.")
   (c/su
-    (c/exec :rm :-f (c/lit (str "/etc/service/*")))))
+    ;; HACK:
+    ;; Remove all symlinks in /etc/service except sshd.
+    ;; This is only relevant when tests are run in Docker because there sshd is started using runit.
+    (c/exec :find (c/lit (str "/etc/service -maxdepth 1 -type l ! -name 'sshd' -delete")))))
 
 Review comment:
   I wonder if excluding by name is not already good enough?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Jepsen: runit supervised sshd is stopped on tear down
> -----------------------------------------------------
>
>                 Key: FLINK-10465
>                 URL: https://issues.apache.org/jira/browse/FLINK-10465
>             Project: Flink
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 1.7.0, 1.6.2
>            Reporter: Gary Yao
>            Assignee: Gary Yao
>            Priority: Critical
>              Labels: pull-request-available
>             Fix For: 1.7.0, 1.6.2
>
>
> When tearing down the _DB_, we tear down all services supervised by runit. However when running the tests in Docker, sshd is under supervision by runit. When sshd is stopped, the tests cannot be continued because the control node cannot interact with the DB nodes anymore.
> *How to reproduce*
> Run command below in control-node container:
> {code}
> ./docker/run-tests.sh 1 [...]/flink/flink-1.6.1/flink-1.6.1-bin-hadoop28-scala_2.11.tgz
> {code}
> *Expected behavior*
> sshd should never be stopped



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)