You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2020/12/15 15:51:09 UTC
[GitHub] [hadoop] bilaharith opened a new pull request #2551: ADLS Gen1: Updating gen1 SDK version from 2.3.6 to 2.3.9
bilaharith opened a new pull request #2551:
URL: https://github.com/apache/hadoop/pull/2551
Updating gen1 SDK version from 2.3.6 to 2.3.9
**Before the change**
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] TestAdlContractRenameLive>AbstractContractRenameTest.testRenameFileOverExistingFile:131->Assert.fail:88 expected rename(adl://bithgen1it.azuredatalakestore.net/test/source-256.txt, adl://bithgen1it.azuredatalakestore.net/test/dest-512.txt) to be rejected with exception, but got false
[ERROR] TestAdlContractRenameLive.testRenameFileUnderFile:46 Expecting org.apache.hadoop.security.AccessControlException with text Parent path is not a folder. but got : "void"
[ERROR] Errors:
[ERROR] TestAdlContractGetFileStatusLive>AbstractContractGetFileStatusTest.testComplexDirActions:153->AbstractContractGetFileStatusTest.checkListStatusIteratorComplexDir:196 » NoClassDefFound
[ERROR] TestAdlContractGetFileStatusLive>AbstractContractGetFileStatusTest.testListStatusIteratorFile:363->AbstractContractGetFileStatusTest.validateListingForFile:384 » NoClassDefFound
[ERROR] TestAdlContractRootDirLive>AbstractContractRootDirectoryTest.testSimpleRootListing:251 » NoClassDefFound
[INFO]
[ERROR] Tests run: 893, Failures: 2, Errors: 3, Skipped: 3
**After the change**
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] TestAdlContractRenameLive>AbstractContractRenameTest.testRenameFileOverExistingFile:131->Assert.fail:88 expected rename(adl://bithgen1it.azuredatalakestore.net/test/source-256.txt, adl://bithgen1it.azuredatalakestore.net/test/dest-512.txt) to be rejected with exception, but got false
[ERROR] TestAdlContractRenameLive.testRenameFileUnderFile:46 Expecting org.apache.hadoop.security.AccessControlException with text Parent path is not a folder. but got : "void"
[ERROR] Errors:
[ERROR] TestAdlContractGetFileStatusLive>AbstractContractGetFileStatusTest.testComplexDirActions:153->AbstractContractGetFileStatusTest.checkListStatusIteratorComplexDir:196 » NoClassDefFound
[ERROR] TestAdlContractGetFileStatusLive>AbstractContractGetFileStatusTest.testListStatusIteratorFile:363->AbstractContractGetFileStatusTest.validateListingForFile:384 » NoClassDefFound
[ERROR] TestAdlContractRootDirLive>AbstractContractRootDirectoryTest.testSimpleRootListing:251 » NoClassDefFound
[INFO]
[ERROR] Tests run: 893, Failures: 2, Errors: 3, Skipped: 3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] bilaharith commented on a change in pull request #2551: ADLS Gen1: Updating gen1 SDK version from 2.3.6 to 2.3.9
Posted by GitBox <gi...@apache.org>.
bilaharith commented on a change in pull request #2551:
URL: https://github.com/apache/hadoop/pull/2551#discussion_r543486228
##########
File path: hadoop-tools/hadoop-azure-datalake/pom.xml
##########
@@ -166,5 +166,12 @@
<scope>test</scope>
<type>test-jar</type>
</dependency>
+
+ <dependency>
+ <groupId>org.wildfly.openssl</groupId>
+ <artifactId>wildfly-openssl</artifactId>
+ <scope>compile</scope>
+ </dependency>
Review comment:
2.3.9 version of SDK is expecting wildfly dependency.
without the same, nearly all the tests were failing with the following exception.
java.lang.NoClassDefFoundError: Could not initialize class com.microsoft.azure.datalake.store.SSLSocketFactoryEx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] vinaysbadami commented on a change in pull request #2551: ADLS Gen1: Updating gen1 SDK version from 2.3.6 to 2.3.9
Posted by GitBox <gi...@apache.org>.
vinaysbadami commented on a change in pull request #2551:
URL: https://github.com/apache/hadoop/pull/2551#discussion_r543473857
##########
File path: hadoop-tools/hadoop-azure-datalake/pom.xml
##########
@@ -166,5 +166,12 @@
<scope>test</scope>
<type>test-jar</type>
</dependency>
+
+ <dependency>
+ <groupId>org.wildfly.openssl</groupId>
+ <artifactId>wildfly-openssl</artifactId>
+ <scope>compile</scope>
+ </dependency>
Review comment:
why this one now given we have had this dependency forever but have not required this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran merged pull request #2551: HADOOP-17444. ADLS Gen1: Updating gen1 SDK version from 2.3.6 to 2.3.9
Posted by GitBox <gi...@apache.org>.
steveloughran merged pull request #2551:
URL: https://github.com/apache/hadoop/pull/2551
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on pull request #2551: ADLS Gen1: Updating gen1 SDK version from 2.3.6 to 2.3.9
Posted by GitBox <gi...@apache.org>.
steveloughran commented on pull request #2551:
URL: https://github.com/apache/hadoop/pull/2551#issuecomment-748219208
older versions of the library had wildfly embedded inside it, which was a support of pain on its own; presumably later versions pulled it out, which is why it is explicitly needed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2551: ADLS Gen1: Updating gen1 SDK version from 2.3.6 to 2.3.9
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2551:
URL: https://github.com/apache/hadoop/pull/2551#issuecomment-745429338
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 33s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 32m 49s | | trunk passed |
| +1 :green_heart: | compile | 0m 29s | | trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 |
| +1 :green_heart: | compile | 0m 27s | | trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 |
| +1 :green_heart: | mvnsite | 0m 33s | | trunk passed |
| +1 :green_heart: | shadedclient | 49m 46s | | branch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 0m 28s | | trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 |
| +1 :green_heart: | javadoc | 0m 27s | | trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 28s | | the patch passed |
| +1 :green_heart: | compile | 0m 22s | | the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 |
| +1 :green_heart: | javac | 0m 22s | | the patch passed |
| +1 :green_heart: | compile | 0m 18s | | the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 |
| +1 :green_heart: | javac | 0m 18s | | the patch passed |
| +1 :green_heart: | mvnsite | 0m 21s | | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | | The patch has no ill-formed XML file. |
| +1 :green_heart: | shadedclient | 14m 53s | | patch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 0m 23s | | the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 |
| +1 :green_heart: | javadoc | 0m 20s | | the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 57s | | hadoop-azure-datalake in the patch passed. |
| +1 :green_heart: | asflicense | 0m 34s | | The patch does not generate ASF License warnings. |
| | | 72m 39s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2551/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/2551 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml |
| uname | Linux c63e3a37da45 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 5bf977e6b16 |
| Default Java | Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2551/1/testReport/ |
| Max. process+thread count | 535 (vs. ulimit of 5500) |
| modules | C: hadoop-tools/hadoop-azure-datalake U: hadoop-tools/hadoop-azure-datalake |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2551/1/console |
| versions | git=2.17.1 maven=3.6.0 |
| Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on a change in pull request #2551: ADLS Gen1: Updating gen1 SDK version from 2.3.6 to 2.3.9
Posted by GitBox <gi...@apache.org>.
steveloughran commented on a change in pull request #2551:
URL: https://github.com/apache/hadoop/pull/2551#discussion_r545981728
##########
File path: hadoop-tools/hadoop-azure-datalake/pom.xml
##########
@@ -166,5 +166,12 @@
<scope>test</scope>
<type>test-jar</type>
</dependency>
+
+ <dependency>
+ <groupId>org.wildfly.openssl</groupId>
+ <artifactId>wildfly-openssl</artifactId>
+ <scope>compile</scope>
+ </dependency>
Review comment:
just because hadoop-project declares an artifact doesn't mean it comes in on the classpath. hadoop-common compiles with it but doesn't force it downstream, so modules which needed it do have to declare it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] rahuldutta90 commented on a change in pull request #2551: ADLS Gen1: Updating gen1 SDK version from 2.3.6 to 2.3.9
Posted by GitBox <gi...@apache.org>.
rahuldutta90 commented on a change in pull request #2551:
URL: https://github.com/apache/hadoop/pull/2551#discussion_r543571592
##########
File path: hadoop-tools/hadoop-azure-datalake/pom.xml
##########
@@ -166,5 +166,12 @@
<scope>test</scope>
<type>test-jar</type>
</dependency>
+
+ <dependency>
+ <groupId>org.wildfly.openssl</groupId>
+ <artifactId>wildfly-openssl</artifactId>
+ <scope>compile</scope>
+ </dependency>
Review comment:
is there some issue with your local build?
Because it should pull in hadoop-project's pom dependencies (https://github.com/apache/hadoop/blob/df35c7f51996b63a14a3323b40fb75a6f4c29c7d/hadoop-project/pom.xml#L1450) since gen1 driver pom does depend on hadoop-project pom.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] DadanielZ commented on pull request #2551: HADOOP-17444. ADLS Gen1: Updating gen1 SDK version from 2.3.6 to 2.3.9
Posted by GitBox <gi...@apache.org>.
DadanielZ commented on pull request #2551:
URL: https://github.com/apache/hadoop/pull/2551#issuecomment-753515465
any reason why the upgrade is necessary?
@bilaharith do you know who is maintaining the ADL driver? It's better to take a look at those failed tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on pull request #2551: ADLS Gen1: Updating gen1 SDK version from 2.3.6 to 2.3.9
Posted by GitBox <gi...@apache.org>.
steveloughran commented on pull request #2551:
URL: https://github.com/apache/hadoop/pull/2551#issuecomment-748221293
+1, merging. I like the explicit wildfly declaration. Wildfly + openssl versions are a source of pain.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on pull request #2551: ADLS Gen1: Updating gen1 SDK version from 2.3.6 to 2.3.9
Posted by GitBox <gi...@apache.org>.
steveloughran commented on pull request #2551:
URL: https://github.com/apache/hadoop/pull/2551#issuecomment-748224170
@bilaharith before I merge this, file the hadoop JIRA & update the title of this PR to it. I wouldn't even have noticed the patch surfacing if I wasn't trying out code review through Intelllij IDEA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] bilaharith commented on pull request #2551: HADOOP-17444. ADLS Gen1: Updating gen1 SDK version from 2.3.6 to 2.3.9
Posted by GitBox <gi...@apache.org>.
bilaharith commented on pull request #2551:
URL: https://github.com/apache/hadoop/pull/2551#issuecomment-749953809
> @bilaharith before I merge this, file the hadoop JIRA & update the title of this PR to it. I wouldn't even have noticed the patch surfacing if I wasn't trying out code review through Intelllij IDEA.
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on pull request #2551: HADOOP-17444. ADLS Gen1: Updating gen1 SDK version from 2.3.6 to 2.3.9
Posted by GitBox <gi...@apache.org>.
steveloughran commented on pull request #2551:
URL: https://github.com/apache/hadoop/pull/2551#issuecomment-755334143
+1; merged to trunk. Not pulled in to -3.3, but only because the asf repo seems to be out of sync and so I can't easily do the cherrypick
@bilaharith could you do a test run with this PR applied to branch-3.3? No need for a new PR, just do a test run and let us know how it came out
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org