svn commit: r527694 - in /lucene/hadoop/trunk: CHANGES.txt src/java/org/apache/hadoop/ipc/Server.java

[cu...@apache.org]

Author: cutting
Date: Wed Apr 11 14:55:24 2007
New Revision: 527694

URL: http://svn.apache.org/viewvc?view=rev&rev=527694
Log:
HADOOP-1213.  Improve logging of errors by IPC server.

Modified:
    lucene/hadoop/trunk/CHANGES.txt
    lucene/hadoop/trunk/src/java/org/apache/hadoop/ipc/Server.java

Modified: lucene/hadoop/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/lucene/hadoop/trunk/CHANGES.txt?view=diff&rev=527694&r1=527693&r2=527694
==============================================================================
--- lucene/hadoop/trunk/CHANGES.txt (original)
+++ lucene/hadoop/trunk/CHANGES.txt Wed Apr 11 14:55:24 2007
@@ -173,6 +173,9 @@
     deprecate InputFormatBase.  Also make LineRecordReader easier to
     extend.  (Runping Qi via cutting)
 
+53. HADOOP-1213.  Improve logging of errors by IPC server, to
+    consistently include the service name and the call.  (cutting)
+
 
 Release 0.12.3 - 2007-04-06
 

Modified: lucene/hadoop/trunk/src/java/org/apache/hadoop/ipc/Server.java
URL: http://svn.apache.org/viewvc/lucene/hadoop/trunk/src/java/org/apache/hadoop/ipc/Server.java?view=diff&rev=527694&r1=527693&r2=527694
==============================================================================
--- lucene/hadoop/trunk/src/java/org/apache/hadoop/ipc/Server.java (original)
+++ lucene/hadoop/trunk/src/java/org/apache/hadoop/ipc/Server.java Wed Apr 11 14:55:24 2007
@@ -554,8 +554,8 @@
           if (System.currentTimeMillis() - call.receivedTime > 
               maxCallStartAge) {
             ReflectionUtils.logThreadInfo(LOG, "Discarding call " + call, 30);
-            LOG.warn("Call " + call.toString() + 
-                     " discarded for being too old (" +
+            LOG.warn(getName()+", call "+call
+                     +": discarded for being too old (" +
                      (System.currentTimeMillis() - call.receivedTime) + ")");
             continue;
           }
@@ -572,7 +572,7 @@
           try {
             value = call(call.param);             // make the call
           } catch (Throwable e) {
-            LOG.info(getName() + " call error: " + e, e);
+            LOG.info(getName()+", call "+call+": error: " + e, e);
             errorClass = e.getClass().getName();
             error = StringUtils.stringifyException(e);
           }
@@ -591,7 +591,7 @@
               }
               out.flush();
             } catch (Exception e) {
-              LOG.warn("handler output error", e);
+              LOG.warn(getName()+", call "+call+": output error", e);
               synchronized (connectionList) {
                 if (connectionList.remove(call.connection))
                   numConnections--;