[GitHub] [fineract] vidakovic commented on a change in pull request #1934: FINERACT-1418: Upgrade to Jersey 2

[GitBox <gi...@apache.org>]

vidakovic commented on a change in pull request #1934:
URL: https://github.com/apache/fineract/pull/1934#discussion_r742557612



##########
File path: fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/data/ApiGlobalErrorResponse.java
##########
@@ -194,8 +194,7 @@ public ApiGlobalErrorResponse(final List<ApiParameterError> errors) {
         this.errors = errors;
     }
 
-    @XmlElementWrapper(name = "errors")
-    @XmlElement(name = "errorResponse")
+    @JsonProperty("errors")

Review comment:
       @ptuomola isn't this changing the structure of the error response? As I see it from the changes here:
   
   Before:
   
   ```
   <errors>
     <errorResponse>
       ...
     </errorResponse>
     <errorResponse>
       ...
     </errorResponse>
   </errors>
   ```
   
   After:
   
   ```
   <errors>
     <apiParameterError>
       ...
     </apiParameterError>
     <apiParameterError>
       ...
     </apiParameterError>
   </errors>
   ```
   ... if I'm missing something here and the errors still serialize to the same structure then please ignore.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org