You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/19 16:49:36 UTC
[GitHub] [airflow] edithturn opened a new pull request, #23090: Use inclusive words in apache irflow project
edithturn opened a new pull request, #23090:
URL: https://github.com/apache/airflow/pull/23090
Closes: #15994
I am continuing with this issue, this will exclude the following words:
- master
- he
- she
- his
- her
- slave
- sanity
- dummy
- white
- black
Using regex in .pre-commit-config.yaml.
i = Use case-insensitive matching. For more information, (edited)
x = Ignore unescaped white space in the regular expression pattern.
\b = finds/matches the pattern at the beginning or end of each word.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #23090: Use inclusive words in apache airflow project
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #23090:
URL: https://github.com/apache/airflow/pull/23090#issuecomment-1104248254
It was a transient error:
```
error: failed to solve: failed to solve with frontend dockerfile.v0: failed to solve with frontend gateway.v0: failed to authorize: rpc error: code = Unknown desc = failed to fetch oauth token: unexpected status: 502 Bad Gateway
Tagging and pushing the ghcr.io/apache/airflow/main/ci/python3.7 as ghcr.io/apache/airflow/main/ci/python3.7:104d6b374bb80c[85](https://github.com/apache/airflow/runs/6098079064?check_suite_focus=true#step:10:85)a2bb9d9d899fc3f3fc85b2d2.
```
BTW. In this case the build should fail eariler. I already noticed that failing of image build does not fail the job as it should - i already fixed it in upcoming big PR :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] edithturn commented on pull request #23090: Use inclusive words in apache airflow project
Posted by GitBox <gi...@apache.org>.
edithturn commented on PR #23090:
URL: https://github.com/apache/airflow/pull/23090#issuecomment-1116675270
I think I need to rebase :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #23090: Use inclusive words in apache airflow project
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #23090:
URL: https://github.com/apache/airflow/pull/23090#issuecomment-1121127906
Can you please rebase @edithturn - we had some refactoring/changes and this one is now conflicting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ferruzzi commented on a diff in pull request #23090: Use inclusive words in apache irflow project
Posted by GitBox <gi...@apache.org>.
ferruzzi commented on code in PR #23090:
URL: https://github.com/apache/airflow/pull/23090#discussion_r853401505
##########
.pre-commit-config.yaml:
##########
@@ -408,13 +408,25 @@ repos:
language: pygrep
name: Check for language that we do not accept as community
description: Please use "deny_list" or "allow_list" instead.
Review Comment:
This description line should likely be updated as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #23090: Use inclusive words in apache airflow project
Posted by GitBox <gi...@apache.org>.
eladkal commented on code in PR #23090:
URL: https://github.com/apache/airflow/pull/23090#discussion_r853804534
##########
.pre-commit-config.yaml:
##########
@@ -408,13 +408,25 @@ repos:
language: pygrep
name: Check for language that we do not accept as community
description: Please use "deny_list" or "allow_list" instead.
- entry: "(?i)(black|white)[_-]?list"
+ entry: >
+ (?ix)
+ \bmaster\b|
+ \bhe\b|
+ \bshe\b|
+ \bhis\b|
+ \bher\b|
+ \bslave\b|
+ \bsanity\b|
+ \bdummy\b|
+ \bwhite\b|
+ \bblack\b
Review Comment:
maybe we should stay with looking for black/white list.
It will be very difficult to handle colours names without excluding many files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #23090: Use inclusive words in apache airflow project
Posted by GitBox <gi...@apache.org>.
eladkal commented on code in PR #23090:
URL: https://github.com/apache/airflow/pull/23090#discussion_r864069273
##########
.pre-commit-config.yaml:
##########
@@ -428,19 +428,38 @@ repos:
- id: check-for-inclusive-language
language: pygrep
name: Check for language that we do not accept as community
- description: Please use "deny_list" or "allow_list" instead.
- entry: "(?i)(black|white)[_-]?list"
+ description: Please use more appropriate words for community documentation.
+ entry: >
+ (?i)
+ (black|white)[_-]?list|
+ \bshe\b|
+ \bhe\b|
+ \bher\b|
+ \bhis\b|
+ \bmaster\b|
+ \bslave\b|
+ \bsanity\b|
+ \bdummy\b
pass_filenames: true
exclude: >
(?x)
- ^airflow/www/fab_security/manager\.py$|
- ^airflow/providers/apache/cassandra/hooks/cassandra\.py$|
- ^airflow/providers/apache/hive/operators/hive_stats\.py$|
- ^airflow/providers/apache/hive/.*PROVIDER_CHANGES_*|
- ^airflow/providers/apache/hive/.*README\.md$|
- ^tests/providers/apache/cassandra/hooks/test_cassandra\.py$|
- ^docs/apache-airflow-providers-apache-cassandra/connections/cassandra\.rst$|
- ^docs/apache-airflow-providers-apache-hive/commits\.rst$|
+ ^airflow/www/fab_security/manager.py$|
+ ^airflow/www/static/|
+ ^airflow/providers/|
+ ^tests/providers/apache/cassandra/hooks/test_cassandra.py$|
+ ^docs/apache-airflow-providers-apache-cassandra/connections/cassandra.rst$|
+ ^docs/apache-airflow-providers-apache-hive/commits.rst$|
+ ^airflow/api_connexion/openapi/v1.yaml$|
+ ^tests/cli/commands/test_webserver_command.py$|
+ ^airflow/cli/commands/webserver_command.py$|
+ ^airflow/ui/yarn.lock$|
+ ^airflow/config_templates/default_airflow.cfg$|
+ ^airflow/config_templates/config.yml$|
+ ^docs/*.*$|
+ ^tests/providers/|
+ ^.pre-commit-config\.yaml$|
+ ^.*RELEASE_NOTES\.rst$|
+ ^.*CHANGELOG\.txt$|^.*CHANGELOG\.rst$|
Review Comment:
~~why twice?~~
Ah NVM. I'm blind
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] edithturn commented on pull request #23090: Use inclusive words in apache airflow project
Posted by GitBox <gi...@apache.org>.
edithturn commented on PR #23090:
URL: https://github.com/apache/airflow/pull/23090#issuecomment-1121451098
@potiuk I did it, I hope the Rebase is ok, please let me know if something is wrong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #23090: Use inclusive words in apache airflow project
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #23090:
URL: https://github.com/apache/airflow/pull/23090
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] edithturn commented on pull request #23090: Use inclusive words in apache airflow project
Posted by GitBox <gi...@apache.org>.
edithturn commented on PR #23090:
URL: https://github.com/apache/airflow/pull/23090#issuecomment-1104243835
I am not sure why build images are failing: https://github.com/apache/airflow/actions/runs/2196758091
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a diff in pull request #23090: Use inclusive words in apache airflow project
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on code in PR #23090:
URL: https://github.com/apache/airflow/pull/23090#discussion_r860078570
##########
airflow/config_templates/config.yml:
##########
@@ -1066,7 +1066,7 @@
default: database
- name: web_server_master_timeout
description: |
- Number of seconds the webserver waits before killing gunicorn master that doesn't respond
+ Number of seconds the webserver waits before killing gunicorn main that doesn't respond
Review Comment:
I'm torn on this one, as I'm not sure we should deviate from the terminology gunicorn uses?
https://docs.gunicorn.org/en/latest/design.html#master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] edithturn commented on a diff in pull request #23090: Use inclusive words in apache airflow project
Posted by GitBox <gi...@apache.org>.
edithturn commented on code in PR #23090:
URL: https://github.com/apache/airflow/pull/23090#discussion_r860287855
##########
airflow/config_templates/config.yml:
##########
@@ -1066,7 +1066,7 @@
default: database
- name: web_server_master_timeout
description: |
- Number of seconds the webserver waits before killing gunicorn master that doesn't respond
+ Number of seconds the webserver waits before killing gunicorn main that doesn't respond
Review Comment:
Totally agree with this , thank you for the feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] edithturn commented on pull request #23090: Use inclusive words in apache airflow project
Posted by GitBox <gi...@apache.org>.
edithturn commented on PR #23090:
URL: https://github.com/apache/airflow/pull/23090#issuecomment-1121621186
wohoo! Thank you! 🙌🏽💃🏽
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] edithturn commented on pull request #23090: Use inclusive words in apache airflow project
Posted by GitBox <gi...@apache.org>.
edithturn commented on PR #23090:
URL: https://github.com/apache/airflow/pull/23090#issuecomment-1109357220
@eladkal I am wondering why some things are not possible to replicate in the local machine, for example, these regular expressions added in pre-commits are just showing the OutPut on CI, but not in the local testing.
The environments are different but pre commits are just based on source code, the output should be the same.
Is there some **cache** for GitHub actions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] edithturn commented on pull request #23090: Use inclusive words in apache irflow project
Posted by GitBox <gi...@apache.org>.
edithturn commented on PR #23090:
URL: https://github.com/apache/airflow/pull/23090#issuecomment-1102891421
@eladkal I am not sure why we are excluding these files. Some of them exist and some don't. Some are from "provider/docs", so I am assuming that they are being excluded because we are using third-party documentation that we cannot change after validation.
(Exist) ^airflow/www/fab_security/manager\.py$|
(Exist) ^airflow/providers/apache/cassandra/hooks/cassandra\.py$|
(Exist) ^airflow/providers/apache/hive/operators/hive_stats\.py$|
(Exist) ^.pre-commit-config\.yaml$|
(Doesn't Exist) ^airflow/providers/apache/hive/.*PROVIDER_CHANGES_*|
(Doesn't Exist) ^airflow/providers/apache/hive/.*README\.md$|
(Exist) ^tests/providers/apache/cassandra/hooks/test_cassandra\.py$|
(Exist) ^docs/apache-airflow-providers-apache-cassandra/connections/cassandra\.rst$|
(Exist) ^docs/apache-airflow-providers-apache-hive/commits\.rst$|
(Doesn't Exist) git
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] edithturn commented on pull request #23090: Use inclusive words in apache airflow project
Posted by GitBox <gi...@apache.org>.
edithturn commented on PR #23090:
URL: https://github.com/apache/airflow/pull/23090#issuecomment-1105253188
@potiuk thank you for letting us know :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #23090: Use inclusive words in apache airflow project
Posted by GitBox <gi...@apache.org>.
eladkal commented on code in PR #23090:
URL: https://github.com/apache/airflow/pull/23090#discussion_r864069273
##########
.pre-commit-config.yaml:
##########
@@ -428,19 +428,38 @@ repos:
- id: check-for-inclusive-language
language: pygrep
name: Check for language that we do not accept as community
- description: Please use "deny_list" or "allow_list" instead.
- entry: "(?i)(black|white)[_-]?list"
+ description: Please use more appropriate words for community documentation.
+ entry: >
+ (?i)
+ (black|white)[_-]?list|
+ \bshe\b|
+ \bhe\b|
+ \bher\b|
+ \bhis\b|
+ \bmaster\b|
+ \bslave\b|
+ \bsanity\b|
+ \bdummy\b
pass_filenames: true
exclude: >
(?x)
- ^airflow/www/fab_security/manager\.py$|
- ^airflow/providers/apache/cassandra/hooks/cassandra\.py$|
- ^airflow/providers/apache/hive/operators/hive_stats\.py$|
- ^airflow/providers/apache/hive/.*PROVIDER_CHANGES_*|
- ^airflow/providers/apache/hive/.*README\.md$|
- ^tests/providers/apache/cassandra/hooks/test_cassandra\.py$|
- ^docs/apache-airflow-providers-apache-cassandra/connections/cassandra\.rst$|
- ^docs/apache-airflow-providers-apache-hive/commits\.rst$|
+ ^airflow/www/fab_security/manager.py$|
+ ^airflow/www/static/|
+ ^airflow/providers/|
+ ^tests/providers/apache/cassandra/hooks/test_cassandra.py$|
+ ^docs/apache-airflow-providers-apache-cassandra/connections/cassandra.rst$|
+ ^docs/apache-airflow-providers-apache-hive/commits.rst$|
+ ^airflow/api_connexion/openapi/v1.yaml$|
+ ^tests/cli/commands/test_webserver_command.py$|
+ ^airflow/cli/commands/webserver_command.py$|
+ ^airflow/ui/yarn.lock$|
+ ^airflow/config_templates/default_airflow.cfg$|
+ ^airflow/config_templates/config.yml$|
+ ^docs/*.*$|
+ ^tests/providers/|
+ ^.pre-commit-config\.yaml$|
+ ^.*RELEASE_NOTES\.rst$|
+ ^.*CHANGELOG\.txt$|^.*CHANGELOG\.rst$|
Review Comment:
why twice?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #23090: Use inclusive words in apache airflow project
Posted by GitBox <gi...@apache.org>.
eladkal commented on code in PR #23090:
URL: https://github.com/apache/airflow/pull/23090#discussion_r854260539
##########
.pre-commit-config.yaml:
##########
@@ -407,19 +407,29 @@ repos:
- id: language-matters
language: pygrep
name: Check for language that we do not accept as community
- description: Please use "deny_list" or "allow_list" instead.
- entry: "(?i)(black|white)[_-]?list"
+ description: Please use more appropriate words for community documentation.
+ entry: >
+ (?ix)
+ (black|white)[_-]?list|
+ \bmaster\b|
+ \bhe\b|
+ \bshe\b|
+ \bhis\b|
+ \bher\b|
+ \bslave\b|
+ \bsanity\b|
+ \bdummy\b|
pass_filenames: true
exclude: >
(?x)
^airflow/www/fab_security/manager\.py$|
^airflow/providers/apache/cassandra/hooks/cassandra\.py$|
^airflow/providers/apache/hive/operators/hive_stats\.py$|
- ^airflow/providers/apache/hive/.*PROVIDER_CHANGES_*|
- ^airflow/providers/apache/hive/.*README\.md$|
^tests/providers/apache/cassandra/hooks/test_cassandra\.py$|
^docs/apache-airflow-providers-apache-cassandra/connections/cassandra\.rst$|
^docs/apache-airflow-providers-apache-hive/commits\.rst$|
+ ^.pre-commit-config\.yaml$|
+ ^.*CHANGELOG\.txt$|CHANGELOG\.rst$
Review Comment:
I think you are missing `|` here ?
```suggestion
^.*CHANGELOG\.txt$|CHANGELOG\.rst$|
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] edithturn commented on pull request #23090: Use inclusive words in apache airflow project
Posted by GitBox <gi...@apache.org>.
edithturn commented on PR #23090:
URL: https://github.com/apache/airflow/pull/23090#issuecomment-1111662620
@jedcunningham @eladkal I think this is ready, could you please review it when you are free :)
Let me know any feedback
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #23090: Use inclusive words in apache airflow project
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23090:
URL: https://github.com/apache/airflow/pull/23090#issuecomment-1116419891
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #23090: Use inclusive words in apache airflow project
Posted by GitBox <gi...@apache.org>.
eladkal commented on code in PR #23090:
URL: https://github.com/apache/airflow/pull/23090#discussion_r860105333
##########
airflow/config_templates/config.yml:
##########
@@ -1066,7 +1066,7 @@
default: database
- name: web_server_master_timeout
description: |
- Number of seconds the webserver waits before killing gunicorn master that doesn't respond
+ Number of seconds the webserver waits before killing gunicorn main that doesn't respond
Review Comment:
Yes this might be a case where we should exclude the file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org