You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/20 13:13:09 UTC
[GitHub] [arrow] mennosiek opened a new pull request #10365: Update SetupCxxFlags.cmake for powerpc
mennosiek opened a new pull request #10365:
URL: https://github.com/apache/arrow/pull/10365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #10365: ARROW-12836: [C++] Add support for newer IBM i
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #10365:
URL: https://github.com/apache/arrow/pull/10365#discussion_r636480453
##########
File path: cpp/cmake_modules/SetupCxxFlags.cmake
##########
@@ -28,7 +28,7 @@ if(NOT DEFINED ARROW_CPU_FLAG)
set(ARROW_CPU_FLAG "armv8")
elseif(CMAKE_SYSTEM_PROCESSOR MATCHES "armv7")
set(ARROW_CPU_FLAG "armv7")
- elseif(CMAKE_SYSTEM_PROCESSOR MATCHES "ppc")
+ elseif(CMAKE_SYSTEM_PROCESSOR MATCHES "powerpc|powerpc64|ppc")
Review comment:
OK. I'll apply it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10365: Update SetupCxxFlags.cmake for powerpc
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10365:
URL: https://github.com/apache/arrow/pull/10365#issuecomment-845114879
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mennosiek commented on a change in pull request #10365: ARROW-12836: [C++] Add support for newer IBM i
Posted by GitBox <gi...@apache.org>.
mennosiek commented on a change in pull request #10365:
URL: https://github.com/apache/arrow/pull/10365#discussion_r636472236
##########
File path: cpp/cmake_modules/SetupCxxFlags.cmake
##########
@@ -28,7 +28,7 @@ if(NOT DEFINED ARROW_CPU_FLAG)
set(ARROW_CPU_FLAG "armv8")
elseif(CMAKE_SYSTEM_PROCESSOR MATCHES "armv7")
set(ARROW_CPU_FLAG "armv7")
- elseif(CMAKE_SYSTEM_PROCESSOR MATCHES "ppc")
+ elseif(CMAKE_SYSTEM_PROCESSOR MATCHES "powerpc|powerpc64|ppc")
Review comment:
Yes, that will work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #10365: ARROW-12836: [C++] Add support for newer IBM i
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #10365:
URL: https://github.com/apache/arrow/pull/10365#discussion_r636469587
##########
File path: cpp/cmake_modules/SetupCxxFlags.cmake
##########
@@ -28,7 +28,7 @@ if(NOT DEFINED ARROW_CPU_FLAG)
set(ARROW_CPU_FLAG "armv8")
elseif(CMAKE_SYSTEM_PROCESSOR MATCHES "armv7")
set(ARROW_CPU_FLAG "armv7")
- elseif(CMAKE_SYSTEM_PROCESSOR MATCHES "ppc")
+ elseif(CMAKE_SYSTEM_PROCESSOR MATCHES "powerpc|powerpc64|ppc")
Review comment:
It seems that `poerpc64` is redundant.
Does the following pattern work?
```suggestion
elseif(CMAKE_SYSTEM_PROCESSOR MATCHES "powerpc|ppc")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10365: ARROW-12836: [C++] arrow binary install for ibm i fails because of CxxFlags
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10365:
URL: https://github.com/apache/arrow/pull/10365#issuecomment-845380455
https://issues.apache.org/jira/browse/ARROW-12836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed pull request #10365: ARROW-12836: [C++] Add support for newer IBM i
Posted by GitBox <gi...@apache.org>.
kou closed pull request #10365:
URL: https://github.com/apache/arrow/pull/10365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org