You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by jm...@apache.org on 2016/12/16 05:17:39 UTC
svn commit: r1774556 - in /poi/trunk/src/ooxml/java/org/apache/poi/xwpf:
model/WMLHelper.java usermodel/XWPFTableRow.java
Author: jmarkmurphy
Date: Fri Dec 16 05:17:38 2016
New Revision: 1774556
URL: http://svn.apache.org/viewvc?rev=1774556&view=rev
Log:
Findbugs fix
Modified:
poi/trunk/src/ooxml/java/org/apache/poi/xwpf/model/WMLHelper.java
poi/trunk/src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFTableRow.java
Modified: poi/trunk/src/ooxml/java/org/apache/poi/xwpf/model/WMLHelper.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xwpf/model/WMLHelper.java?rev=1774556&r1=1774555&r2=1774556&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/xwpf/model/WMLHelper.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/xwpf/model/WMLHelper.java Fri Dec 16 05:17:38 2016
@@ -20,14 +20,14 @@ import org.openxmlformats.schemas.wordpr
public final class WMLHelper {
- public static boolean STOnOffToBoolean (STOnOff.Enum value) {
+ public static boolean convertSTOnOffToBoolean (STOnOff.Enum value) {
if (value == STOnOff.TRUE || value == STOnOff.ON || value == STOnOff.X_1) {
return true;
}
return false;
}
- public static STOnOff.Enum BooleanToSTOnOff (boolean value) {
+ public static STOnOff.Enum convertBooleanToSTOnOff (boolean value) {
return (value ? STOnOff.TRUE : STOnOff.FALSE);
}
}
Modified: poi/trunk/src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFTableRow.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFTableRow.java?rev=1774556&r1=1774555&r2=1774556&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFTableRow.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFTableRow.java Fri Dec 16 05:17:38 2016
@@ -30,7 +30,6 @@ import org.openxmlformats.schemas.wordpr
import org.openxmlformats.schemas.wordprocessingml.x2006.main.CTSdtCell;
import org.openxmlformats.schemas.wordprocessingml.x2006.main.CTTc;
import org.openxmlformats.schemas.wordprocessingml.x2006.main.CTTrPr;
-import org.openxmlformats.schemas.wordprocessingml.x2006.main.STOnOff;
/**
@@ -197,7 +196,7 @@ public class XWPFTableRow {
CTTrPr trpr = getTrPr();
if (trpr.sizeOfCantSplitArray() > 0) {
CTOnOff onoff = trpr.getCantSplitArray(0);
- isCant = (onoff.isSetVal() ? WMLHelper.STOnOffToBoolean(onoff.getVal()) : true);
+ isCant = (onoff.isSetVal() ? WMLHelper.convertSTOnOffToBoolean(onoff.getVal()) : true);
}
}
return isCant;
@@ -214,7 +213,7 @@ public class XWPFTableRow {
public void setCantSplitRow(boolean split) {
CTTrPr trpr = getTrPr();
CTOnOff onoff = (trpr.sizeOfCantSplitArray() > 0 ? trpr.getCantSplitArray(0) : trpr.addNewCantSplit());
- onoff.setVal(WMLHelper.BooleanToSTOnOff(split));
+ onoff.setVal(WMLHelper.convertBooleanToSTOnOff(split));
}
/**
@@ -244,7 +243,7 @@ public class XWPFTableRow {
CTTrPr trpr = getTrPr();
if (trpr.sizeOfTblHeaderArray() > 0) {
CTOnOff rpt = trpr.getTblHeaderArray(0);
- repeat = (rpt.isSetVal() ? WMLHelper.STOnOffToBoolean(rpt.getVal()) : true);
+ repeat = (rpt.isSetVal() ? WMLHelper.convertSTOnOffToBoolean(rpt.getVal()) : true);
}
}
return repeat;
@@ -261,6 +260,6 @@ public class XWPFTableRow {
public void setRepeatHeader(boolean repeat) {
CTTrPr trpr = getTrPr();
CTOnOff onoff = (trpr.sizeOfTblHeaderArray() > 0 ? trpr.getTblHeaderArray(0) : trpr.addNewTblHeader());
- onoff.setVal(WMLHelper.BooleanToSTOnOff(repeat));
+ onoff.setVal(WMLHelper.convertBooleanToSTOnOff(repeat));
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org