You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "michael-s-molina (via GitHub)" <gi...@apache.org> on 2023/04/25 17:42:29 UTC
[GitHub] [superset] michael-s-molina opened a new pull request, #23818: fix(revert): Reverts storybook-addon-mock inclusion
michael-s-molina opened a new pull request, #23818:
URL: https://github.com/apache/superset/pull/23818
### SUMMARY
Many of our stories in Storybook are throwing errors. After intensive investigation and the help of `git bisect`, I was able track the inclusion of `storybook-addon-mock` dependency in #23429 as the root cause for the errors. I investigated for a couple of hours to understand the reason why it was generating the errors but I wasn't able to resolve the issue. During the investigation I found that there is an [open issue](https://github.com/linearlabs-workspace/storybook-addon-mock/issues/139) with the addon that also need to be addressed. Given that this is affecting many stories, this PR reverts that dependency to give us time to further investigate the problem without blocking Storybook development.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<img width="1762" alt="Screenshot 2023-04-25 at 14 41 07" src="https://user-images.githubusercontent.com/70410625/234358428-c38f45d0-3aff-4af5-9462-9378710d17a6.png">
### TESTING INSTRUCTIONS
Make sure the errors above don't happen.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina merged pull request #23818: fix(revert): Reverts storybook-addon-mock inclusion
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina merged PR #23818:
URL: https://github.com/apache/superset/pull/23818
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #23818: fix(revert): Reverts storybook-addon-mock inclusion
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23818:
URL: https://github.com/apache/superset/pull/23818#issuecomment-1522381725
## [Codecov](https://codecov.io/gh/apache/superset/pull/23818?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23818](https://codecov.io/gh/apache/superset/pull/23818?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (539d9c0) into [master](https://codecov.io/gh/apache/superset/commit/7e4be7d1eab0265d0098b05d33eb2003671dddca?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7e4be7d) will **increase** coverage by `0.01%`.
> The diff coverage is `75.00%`.
> :exclamation: Current head 539d9c0 differs from pull request most recent head 644f033. Consider uploading reports for the commit 644f033 to get more accurate results
```diff
@@ Coverage Diff @@
## master #23818 +/- ##
==========================================
+ Coverage 68.00% 68.01% +0.01%
==========================================
Files 1936 1937 +1
Lines 74929 74936 +7
Branches 8141 8141
==========================================
+ Hits 50955 50970 +15
+ Misses 21886 21878 -8
Partials 2088 2088
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `54.27% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/23818?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...metadataBar/DatasetMetadataBar.skipped-stories.tsx](https://codecov.io/gh/apache/superset/pull/23818?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVzL2RhdGFzZXRzL21ldGFkYXRhQmFyL0RhdGFzZXRNZXRhZGF0YUJhci5za2lwcGVkLXN0b3JpZXMudHN4) | `0.00% <ø> (ø)` | |
| [superset/row\_level\_security/schemas.py](https://codecov.io/gh/apache/superset/pull/23818?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcm93X2xldmVsX3NlY3VyaXR5L3NjaGVtYXMucHk=) | `100.00% <ø> (ø)` | |
| [superset/row\_level\_security/commands/update.py](https://codecov.io/gh/apache/superset/pull/23818?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcm93X2xldmVsX3NlY3VyaXR5L2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `91.66% <50.00%> (ø)` | |
| [superset/row\_level\_security/commands/create.py](https://codecov.io/gh/apache/superset/pull/23818?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcm93X2xldmVsX3NlY3VyaXR5L2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `100.00% <100.00%> (ø)` | |
... and [5 files with indirect coverage changes](https://codecov.io/gh/apache/superset/pull/23818/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org