You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/06/23 11:11:44 UTC

[GitHub] [shardingsphere] tristaZero opened a new issue #6177: Add unit test case for #4665

tristaZero opened a new issue #6177:
URL: https://github.com/apache/shardingsphere/issues/6177


   Although #4680 was fixed by #4665, it is necessary to add a unit test to cover that special scenario. Besides, the check style of #4665 is needed to take care of as well. Please consider the items below.
   - [ ] Remove the redundant blank line in 146 Line of `GroupByMemoryMergedResult`
   - [ ] Instead of `tab`, lines beginning with 4 white spaces are preferable in `GroupByMemoryMergedResult `
   - [ ] Add a unit test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] terrymanu closed issue #6177: Add unit test case for #4665

Posted by GitBox <gi...@apache.org>.
terrymanu closed issue #6177:
URL: https://github.com/apache/shardingsphere/issues/6177


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] kimmking commented on issue #6177: Add unit test case for #4665

Posted by GitBox <gi...@apache.org>.
kimmking commented on issue #6177:
URL: https://github.com/apache/shardingsphere/issues/6177#issuecomment-648105059


   FOLLOW IT.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org