[GitHub] [superset] hughhhh commented on a change in pull request #18001: feat: shorter timeout on test_connection

[GitBox <gi...@apache.org>]

hughhhh commented on a change in pull request #18001:
URL: https://github.com/apache/superset/pull/18001#discussion_r782478157



##########
File path: superset/databases/commands/test_connection.py
##########
@@ -78,7 +81,24 @@ def run(self) -> None:
             )
             with closing(engine.raw_connection()) as conn:
                 try:
+                    alive = func_timeout(

Review comment:
       can we add a small test for handling the func_timeout throwing and verify the the error payload come back how we want it?
   
   I'm thinking a 408 status code would good ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org