You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Laszlo Gaal (Code Review)" <ge...@cloudera.org> on 2023/02/06 16:39:54 UTC

[Impala-ASF-CR](asf-site) IMPALA-11899: Add mandatory links to the Impala Apache home page

Laszlo Gaal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19477


Change subject: IMPALA-11899: Add mandatory links to the Impala Apache home page
......................................................................

IMPALA-11899: Add mandatory links to the Impala Apache home page

The Apache Foundation has a number of requirements for TLP websites,
which are checked regularly, with reports being published
whimsy.apache.org.

Impala failed in two categories: missing a copyright notice, and missing
a link to the Apache Privacy Policy.

This change to the Impala home page adds both.

It also fixes a misindented source line, and wraps the whole footer into
the <center> tag originally reserved for the events box.

Tested by loading the local copy of the page into Chrome and Impala on
my system.

Change-Id: Ibbb491fe2ec3c15305c3c66f1e8857a98fced10f
---
M index.html
1 file changed, 7 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/19477/1
-- 
To view, visit http://gerrit.cloudera.org:8080/19477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibbb491fe2ec3c15305c3c66f1e8857a98fced10f
Gerrit-Change-Number: 19477
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>

[Impala-ASF-CR](asf-site) IMPALA-11899: Add mandatory links to the Impala Apache home page

Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19477 )

Change subject: IMPALA-11899: Add mandatory links to the Impala Apache home page
......................................................................

IMPALA-11899: Add mandatory links to the Impala Apache home page

The Apache Foundation has a number of requirements for TLP websites,
which are checked regularly, with reports being published
whimsy.apache.org.

Impala failed in two categories: missing a copyright notice, and missing
a link to the Apache Privacy Policy.

This change to the Impala home page adds both.

It also fixes a misindented source line, and wraps the whole footer into
the <center> tag originally reserved for the events box.

Tested by loading the local copy of the page into Chrome and Firefox on
my system.

Change-Id: Ibbb491fe2ec3c15305c3c66f1e8857a98fced10f
Reviewed-on: http://gerrit.cloudera.org:8080/19477
Reviewed-by: Michael Smith <mi...@cloudera.com>
Tested-by: Laszlo Gaal <la...@cloudera.com>
---
M index.html
1 file changed, 10 insertions(+), 5 deletions(-)

Approvals:
  Michael Smith: Looks good to me, approved
  Laszlo Gaal: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/19477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibbb491fe2ec3c15305c3c66f1e8857a98fced10f
Gerrit-Change-Number: 19477
Gerrit-PatchSet: 3
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR](asf-site) IMPALA-11899: Add mandatory links to the Impala Apache home page

Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19477 )

Change subject: IMPALA-11899: Add mandatory links to the Impala Apache home page
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbb491fe2ec3c15305c3c66f1e8857a98fced10f
Gerrit-Change-Number: 19477
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Feb 2023 16:53:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR](asf-site) IMPALA-11899: Add mandatory links to the Impala Apache home page

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/19477 )

Change subject: IMPALA-11899: Add mandatory links to the Impala Apache home page
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbb491fe2ec3c15305c3c66f1e8857a98fced10f
Gerrit-Change-Number: 19477
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Feb 2023 17:10:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR](asf-site) IMPALA-11899: Add mandatory links to the Impala Apache home page

Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/19477 )

Change subject: IMPALA-11899: Add mandatory links to the Impala Apache home page
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbb491fe2ec3c15305c3c66f1e8857a98fced10f
Gerrit-Change-Number: 19477
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 Feb 2023 13:58:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR](asf-site) IMPALA-11899: Add mandatory links to the Impala Apache home page

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19477 )

Change subject: IMPALA-11899: Add mandatory links to the Impala Apache home page
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbb491fe2ec3c15305c3c66f1e8857a98fced10f
Gerrit-Change-Number: 19477
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Feb 2023 17:06:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR](asf-site) IMPALA-11899: Add mandatory links to the Impala Apache home page

Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Hello Daniel Becker, Zoltan Borok-Nagy, Joe McDonnell, Csaba Ringhofer, Michael Smith, Impala Public Jenkins, Jim Apple, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19477

to look at the new patch set (#2).

Change subject: IMPALA-11899: Add mandatory links to the Impala Apache home page
......................................................................

IMPALA-11899: Add mandatory links to the Impala Apache home page

The Apache Foundation has a number of requirements for TLP websites,
which are checked regularly, with reports being published
whimsy.apache.org.

Impala failed in two categories: missing a copyright notice, and missing
a link to the Apache Privacy Policy.

This change to the Impala home page adds both.

It also fixes a misindented source line, and wraps the whole footer into
the <center> tag originally reserved for the events box.

Tested by loading the local copy of the page into Chrome and Firefox on
my system.

Change-Id: Ibbb491fe2ec3c15305c3c66f1e8857a98fced10f
---
M index.html
1 file changed, 10 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/19477/2
-- 
To view, visit http://gerrit.cloudera.org:8080/19477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibbb491fe2ec3c15305c3c66f1e8857a98fced10f
Gerrit-Change-Number: 19477
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR](asf-site) IMPALA-11899: Add mandatory links to the Impala Apache home page

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19477 )

Change subject: IMPALA-11899: Add mandatory links to the Impala Apache home page
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19477/1/index.html
File index.html:

http://gerrit.cloudera.org:8080/#/c/19477/1/index.html@169
PS1, Line 169:         <p>
nit: Indentation looks off now that everything's in the <center> tag.



-- 
To view, visit http://gerrit.cloudera.org:8080/19477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbb491fe2ec3c15305c3c66f1e8857a98fced10f
Gerrit-Change-Number: 19477
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Feb 2023 19:41:28 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR](asf-site) IMPALA-11899: Add mandatory links to the Impala Apache home page

Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/19477 )

Change subject: IMPALA-11899: Add mandatory links to the Impala Apache home page
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19477/1/index.html
File index.html:

http://gerrit.cloudera.org:8080/#/c/19477/1/index.html@169
PS1, Line 169:           <p>
> nit: Indentation looks off now that everything's in the <center> tag.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/19477
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbb491fe2ec3c15305c3c66f1e8857a98fced10f
Gerrit-Change-Number: 19477
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Feb 2023 15:47:19 +0000
Gerrit-HasComments: Yes