You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by aljoscha <gi...@git.apache.org> on 2018/02/14 13:52:13 UTC
[GitHub] flink pull request #5486: [FLINK-8600] Don't use flaky truncate() test in Bu...
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/5486
[FLINK-8600] Don't use flaky truncate() test in BucketingSink
R: @kl0u
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/flink jira-8600-bucketing-sink-truncate
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5486.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5486
----
commit 4ca30f33f297d66ae5008226eb5d80936e68d887
Author: Aljoscha Krettek <al...@...>
Date: 2018-02-14T13:48:22Z
[FLINK-8600] Don't use flaky truncate() test in BucketingSink
The test was failing when using PrestoS3FileSystem because it doesn't
use an absolute/qualified path. The test was questionable anyways
because it tries writing to a random path that might not be writable by
the user.
This replaces the check with an explicit configuration setting for
enabling/disabling truncate() support.
----
---
[GitHub] flink issue #5486: [FLINK-8600] Don't use flaky truncate() test in Bucketing...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/5486
@kl0u I changed my mind on this. 😅 Now the only change is to allow circumventing the `truncate()` checks via the setting. The checks themselves are still in place. I'm also not changing the call-sites to try and keep the change as localised as possible. WDYT?
---
[GitHub] flink pull request #5486: [FLINK-8600] Don't use flaky truncate() test in Bu...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/5486
---
[GitHub] flink issue #5486: [FLINK-8600] Don't use flaky truncate() test in Bucketing...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/5486
@kl0u Thanks for the review!
I changed the code to check `useTruncate` before calling. Regarding `fsConfig`, the settings in there are for `FileSystem` while the settings that are configured using a setter are for the behaviour of the `BucketingSink` itself. Does that make sense?
---
[GitHub] flink issue #5486: [FLINK-8600] Don't use flaky truncate() test in Bucketing...
Posted by kl0u <gi...@git.apache.org>.
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/5486
@aljoscha Yes it does. I did not get it in the first place but I think that this clarifies things!
---
[GitHub] flink issue #5486: [FLINK-8600] Don't use flaky truncate() test in Bucketing...
Posted by kl0u <gi...@git.apache.org>.
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/5486
+1 to merge.
---
[GitHub] flink issue #5486: [FLINK-8600] Don't use flaky truncate() test in Bucketing...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/5486
(I realised this doesn't add any tests or anything but `BucketingSink` is currently problematic with S3 anyways.)
---