[GitHub] [airflow] ashb commented on a change in pull request #21273: Add test to run DB downgrade in the CI

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #21273:
URL: https://github.com/apache/airflow/pull/21273#discussion_r806704871



##########
File path: airflow/migrations/versions/7b2661a43ba3_taskinstance_keyed_to_dagrun.py
##########
@@ -337,7 +337,7 @@ def downgrade():
         batch_op.drop_constraint('task_instance_pkey', type_='primary')
         batch_op.alter_column('execution_date', existing_type=dt_type, existing_nullable=True, nullable=False)
         batch_op.alter_column(
-            'dag_id', existing_type=string_id_col_type, existing_nullable=True, nullable=True
+            'dag_id', existing_type=string_id_col_type, existing_nullable=True, nullable=False

Review comment:
       If you leave this as not-nullable you haven't correctly reversed the migration.
   
   You'll need to drop the indexes/constraints and re-create them for MSSQL to make this a full downgrade.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org