You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2015/01/23 18:32:58 UTC
Review Request 30217: AMS: Optimize LikeCondition
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30217/
-----------------------------------------------------------
Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
Bugs: AMBARI-9304
https://issues.apache.org/jira/browse/AMBARI-9304
Repository: ambari
Description
-------
Optimize LikeCondition usage based on query parsing
Diffs
-----
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java 83fc0bd
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixTransactSQL.java a6ad040
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestPhoenixTransactSQL.java af472c7
Diff: https://reviews.apache.org/r/30217/diff/
Testing
-------
[INFO] Reactor Summary:
[INFO]
[INFO] ambari-metrics .................................... SUCCESS [0.442s]
[INFO] ambari-metrics-common ............................. SUCCESS [1.751s]
[INFO] ambari-metrics-hadoop-sink ........................ SUCCESS [2.630s]
[INFO] ambari-metrics-flume-sink ......................... SUCCESS [1.434s]
[INFO] ambari-metrics-kafka-sink ......................... SUCCESS [3.120s]
[INFO] ambari-metrics-storm-sink ......................... SUCCESS [0.839s]
[INFO] ambari-metrics-timelineservice .................... SUCCESS [2:54.175s]
[INFO] ambari-metrics-host-monitoring .................... SUCCESS [1.648s]
[INFO] ambari-metrics-assembly ........................... SUCCESS [0.144s]
Thanks,
Dmytro Sen
Re: Review Request 30217: AMS: Optimize LikeCondition
Posted by Dmytro Sen <ds...@hortonworks.com>.
> On Янв. 23, 2015, 5:37 п.п., Sid Wagle wrote:
> > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixTransactSQL.java, line 25
> > <https://reviews.apache.org/r/30217/diff/1/?file=831897#file831897line25>
> >
> > Explicit imports missing.
I'll fix this before commit
- Dmytro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30217/#review69415
-----------------------------------------------------------
On Янв. 23, 2015, 5:32 п.п., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30217/
> -----------------------------------------------------------
>
> (Updated Янв. 23, 2015, 5:32 п.п.)
>
>
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
>
>
> Bugs: AMBARI-9304
> https://issues.apache.org/jira/browse/AMBARI-9304
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Optimize LikeCondition usage based on query parsing
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java 83fc0bd
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixTransactSQL.java a6ad040
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestPhoenixTransactSQL.java af472c7
>
> Diff: https://reviews.apache.org/r/30217/diff/
>
>
> Testing
> -------
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] ambari-metrics .................................... SUCCESS [0.442s]
> [INFO] ambari-metrics-common ............................. SUCCESS [1.751s]
> [INFO] ambari-metrics-hadoop-sink ........................ SUCCESS [2.630s]
> [INFO] ambari-metrics-flume-sink ......................... SUCCESS [1.434s]
> [INFO] ambari-metrics-kafka-sink ......................... SUCCESS [3.120s]
> [INFO] ambari-metrics-storm-sink ......................... SUCCESS [0.839s]
> [INFO] ambari-metrics-timelineservice .................... SUCCESS [2:54.175s]
> [INFO] ambari-metrics-host-monitoring .................... SUCCESS [1.648s]
> [INFO] ambari-metrics-assembly ........................... SUCCESS [0.144s]
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 30217: AMS: Optimize LikeCondition
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30217/#review69415
-----------------------------------------------------------
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixTransactSQL.java
<https://reviews.apache.org/r/30217/#comment114106>
Explicit imports missing.
- Sid Wagle
On Jan. 23, 2015, 5:32 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30217/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2015, 5:32 p.m.)
>
>
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
>
>
> Bugs: AMBARI-9304
> https://issues.apache.org/jira/browse/AMBARI-9304
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Optimize LikeCondition usage based on query parsing
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java 83fc0bd
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixTransactSQL.java a6ad040
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestPhoenixTransactSQL.java af472c7
>
> Diff: https://reviews.apache.org/r/30217/diff/
>
>
> Testing
> -------
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] ambari-metrics .................................... SUCCESS [0.442s]
> [INFO] ambari-metrics-common ............................. SUCCESS [1.751s]
> [INFO] ambari-metrics-hadoop-sink ........................ SUCCESS [2.630s]
> [INFO] ambari-metrics-flume-sink ......................... SUCCESS [1.434s]
> [INFO] ambari-metrics-kafka-sink ......................... SUCCESS [3.120s]
> [INFO] ambari-metrics-storm-sink ......................... SUCCESS [0.839s]
> [INFO] ambari-metrics-timelineservice .................... SUCCESS [2:54.175s]
> [INFO] ambari-metrics-host-monitoring .................... SUCCESS [1.648s]
> [INFO] ambari-metrics-assembly ........................... SUCCESS [0.144s]
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 30217: AMS: Optimize LikeCondition
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30217/#review69434
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On Jan. 23, 2015, 5:32 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30217/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2015, 5:32 p.m.)
>
>
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
>
>
> Bugs: AMBARI-9304
> https://issues.apache.org/jira/browse/AMBARI-9304
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Optimize LikeCondition usage based on query parsing
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java 83fc0bd
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixTransactSQL.java a6ad040
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestPhoenixTransactSQL.java af472c7
>
> Diff: https://reviews.apache.org/r/30217/diff/
>
>
> Testing
> -------
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] ambari-metrics .................................... SUCCESS [0.442s]
> [INFO] ambari-metrics-common ............................. SUCCESS [1.751s]
> [INFO] ambari-metrics-hadoop-sink ........................ SUCCESS [2.630s]
> [INFO] ambari-metrics-flume-sink ......................... SUCCESS [1.434s]
> [INFO] ambari-metrics-kafka-sink ......................... SUCCESS [3.120s]
> [INFO] ambari-metrics-storm-sink ......................... SUCCESS [0.839s]
> [INFO] ambari-metrics-timelineservice .................... SUCCESS [2:54.175s]
> [INFO] ambari-metrics-host-monitoring .................... SUCCESS [1.648s]
> [INFO] ambari-metrics-assembly ........................... SUCCESS [0.144s]
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 30217: AMS: Optimize LikeCondition
Posted by Myroslav Papirkovskyy <mp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30217/#review69413
-----------------------------------------------------------
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Січ. 23, 2015, 7:32 після полудня, Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30217/
> -----------------------------------------------------------
>
> (Updated Січ. 23, 2015, 7:32 після полудня)
>
>
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
>
>
> Bugs: AMBARI-9304
> https://issues.apache.org/jira/browse/AMBARI-9304
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Optimize LikeCondition usage based on query parsing
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java 83fc0bd
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixTransactSQL.java a6ad040
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestPhoenixTransactSQL.java af472c7
>
> Diff: https://reviews.apache.org/r/30217/diff/
>
>
> Testing
> -------
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] ambari-metrics .................................... SUCCESS [0.442s]
> [INFO] ambari-metrics-common ............................. SUCCESS [1.751s]
> [INFO] ambari-metrics-hadoop-sink ........................ SUCCESS [2.630s]
> [INFO] ambari-metrics-flume-sink ......................... SUCCESS [1.434s]
> [INFO] ambari-metrics-kafka-sink ......................... SUCCESS [3.120s]
> [INFO] ambari-metrics-storm-sink ......................... SUCCESS [0.839s]
> [INFO] ambari-metrics-timelineservice .................... SUCCESS [2:54.175s]
> [INFO] ambari-metrics-host-monitoring .................... SUCCESS [1.648s]
> [INFO] ambari-metrics-assembly ........................... SUCCESS [0.144s]
>
>
> Thanks,
>
> Dmytro Sen
>
>