You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/07/24 00:17:01 UTC

[GitHub] [incubator-mxnet] access2rohit commented on pull request #18773: Back port optimization to broadcast_axis to MXNet1.x

access2rohit commented on pull request #18773:
URL: https://github.com/apache/incubator-mxnet/pull/18773#issuecomment-663293595


   > Looks good since it's a cherry-pick.
   > For functionality check, broadcast_axis specific tests in unix-cpu should verify that on CI.
   > For performance check, do you mind pasting comparisons for w/ and w/o this change for 1.x branch just to be sure these perf achievements are valid for 1.x branch as well?
   
   @ChaiBapchya 
   the results are identical to the one I posted on my original PR. These results haven't changed over time. Do you still want additional runs ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org